Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect deprecation notice on some AsciiExt methods #52085

Closed
dtolnay opened this issue Jul 5, 2018 · 1 comment
Closed

Incorrect deprecation notice on some AsciiExt methods #52085

dtolnay opened this issue Jul 5, 2018 · 1 comment
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@dtolnay
Copy link
Member

dtolnay commented Jul 5, 2018

For example AsciiExt::is_ascii_hexdigit says:

This method will be deprecated in favor of the identically-named inherent methods on u8, char, [u8] and str.

But we decided not to carry is_ascii_hexdigit to methods on [u8] and str as discussed in #39658 (comment).

The deprecated methods that are not provided for [u8] and str should instead say something like:

This method will be deprecated in favor of the identically-named inherent methods on u8 and char. For [u8] use .iter().all(u8::is_ascii_hexdigit). For str use .bytes().all(|b| b.is_ascii_hexdigit()).

@varkor varkor added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools labels Jul 6, 2018
@zajlerke
Copy link
Contributor

zajlerke commented Jul 7, 2018

I would like to give this a shot if you don't mind.

kennytm added a commit to kennytm/rust that referenced this issue Jul 12, 2018
… r=Kimundi

Update std::ascii::ASCIIExt deprecation notes

Fixes rust-lang#52085
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this issue Jul 13, 2018
… r=Kimundi

Update std::ascii::ASCIIExt deprecation notes

Fixes rust-lang#52085
kennytm added a commit to kennytm/rust that referenced this issue Jul 13, 2018
… r=Kimundi

Update std::ascii::ASCIIExt deprecation notes

Fixes rust-lang#52085
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Development

No branches or pull requests

3 participants