Simplify handling of feature(bind_by_move_pattern_guards) #59192
Labels
A-NLL
Area: Non Lexical Lifetimes (NLL)
C-cleanup
Category: PRs that clean code up or issues documenting cleanup.
E-easy
Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
E-mentor
Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
P-medium
Medium priority
Comments
matthewjasper
added
A-NLL
|
NLL triage: prioritizing as P-medium. |
bors
added a commit
that referenced
this issue
Apr 22, 2019
Enable NLL migrate mode on the 2015 edition ## What is in this PR? * Remove the `-Zborrowck=ast` flag option from rustc. * The default in the 2015 edition is now `-Zborrowck=migrate`. * The 2018 edition default is unchanged: it's still `-Zborrowck=migrate`. * Enable two-phase borrows (currently toggled via the `-Ztwo-phase-borrows` flag) on all editions. * Remove most dead code that handled these options. * Update tests for the above changes. ## What is *not* in this PR? These are left for future PRs * Use `-Zborrowck=mir` in NLL compare mode tests (#56993) * Remove the `-Zborrowck=compare` option (#59193) * Remove the `-Ztwo-phase-borrows` flag. It's kept, as a flag that does nothing so that perf.rlo has time to stop using it (cc @Mark-Simulacrum) * Remove MIR typeck as its own MIR pass - it's now run by NLL. * Enabling `-Zborrowck=mir` by default (#58781) * Replace `allow_bind_by_move_patterns_with_guards` and `check_for_mutation_in_guard_via_ast_walk` with just using the feature gate. (#59192) Soundness issues that are fixed by NLL will stay open until full NLL is emitting hard errors. However, these diagnostics and completeness issues can now be closed: Closes #18330 Closes #22323 Closes #23591 Closes #26736 Closes #27487 Closes #28092 Closes #28970 Closes #29733 Closes #30104 Closes #38915 Closes #39908 Closes #43407 Closes #47524 Closes #48540 Closes #49073 Closes #52614 Closes #55085 Closes #56093 Closes #56496 Closes #57804 cc #43234 r? @pnkfelix cc @rust-lang/lang cc @rust-lang/wg-compiler-nll
bors
added a commit
that referenced
this issue
Apr 22, 2019
Enable NLL migrate mode on the 2015 edition ## What is in this PR? * Remove the `-Zborrowck=ast` flag option from rustc. * The default in the 2015 edition is now `-Zborrowck=migrate`. * The 2018 edition default is unchanged: it's still `-Zborrowck=migrate`. * Enable two-phase borrows (currently toggled via the `-Ztwo-phase-borrows` flag) on all editions. * Remove most dead code that handled these options. * Update tests for the above changes. ## What is *not* in this PR? These are left for future PRs * Use `-Zborrowck=mir` in NLL compare mode tests (#56993) * Remove the `-Zborrowck=compare` option (#59193) * Remove the `-Ztwo-phase-borrows` flag. It's kept, as a flag that does nothing so that perf.rlo has time to stop using it (cc @Mark-Simulacrum) * Remove MIR typeck as its own MIR pass - it's now run by NLL. * Enabling `-Zborrowck=mir` by default (#58781) * Replace `allow_bind_by_move_patterns_with_guards` and `check_for_mutation_in_guard_via_ast_walk` with just using the feature gate. (#59192) Soundness issues that are fixed by NLL will stay open until full NLL is emitting hard errors. However, these diagnostics and completeness issues can now be closed: Closes #18330 Closes #22323 Closes #23591 Closes #26736 Closes #27487 Closes #28092 Closes #28970 Closes #29733 Closes #30104 Closes #38915 Closes #39908 Closes #43407 Closes #47524 Closes #48540 Closes #49073 Closes #52614 Closes #55085 Closes #56093 Closes #56496 Closes #57804 cc #43234 r? @pnkfelix cc @rust-lang/lang cc @rust-lang/wg-compiler-nll
matthewjasper
added
E-easy
Centril
added a commit
to Centril/rust
that referenced
this issue
Apr 30, 2019
…ewjasper Remove functions to simplify handling of feature(bind_by_move_pattern_guards) Fixes rust-lang#59192 r? @matthewjasper
Centril
added a commit
to Centril/rust
that referenced
this issue
Apr 30, 2019
…ewjasper Remove functions to simplify handling of feature(bind_by_move_pattern_guards) Fixes rust-lang#59192 r? @matthewjasper
Centril
added a commit
to Centril/rust
that referenced
this issue
Apr 30, 2019
…ewjasper Remove functions to simplify handling of feature(bind_by_move_pattern_guards) Fixes rust-lang#59192 r? @matthewjasper
Centril
added a commit
to Centril/rust
that referenced
this issue
Apr 30, 2019
…ewjasper Remove functions to simplify handling of feature(bind_by_move_pattern_guards) Fixes rust-lang#59192 r? @matthewjasper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Current handling of this feature goes through functions
allow_bind_by_move_patterns_with_guardsandcheck_for_mutation_in_guard_via_ast_walk. One or both of these functions should be removed.cc #15287
The text was updated successfully, but these errors were encountered: