Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Anchor to trait item in rustdoc does not expand the trait #70476

Closed
antoyo opened this issue Mar 27, 2020 · 0 comments · Fixed by #70563
Closed

Anchor to trait item in rustdoc does not expand the trait #70476

antoyo opened this issue Mar 27, 2020 · 0 comments · Fixed by #70563
Assignees
@GuillaumeGomez
Labels
C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@antoyo
Copy link
Contributor

antoyo commented Mar 27, 2020

The link https://docs.rs/webkit2gtk/0.9.0/webkit2gtk/struct.WebViewClass.html#get_type.v does not expand the trait, so we don't see the anchor.

cc @GuillaumeGomez
@antoyo antoyo added the C-bug Category: This is a bug. label Mar 27, 2020
@GuillaumeGomez GuillaumeGomez self-assigned this Mar 27, 2020
@GuillaumeGomez GuillaumeGomez added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Mar 27, 2020
@GuillaumeGomez GuillaumeGomez mentioned this issue Mar 30, 2020
Merged
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Jul 6, 2020
@Dylan-DPC
Rollup merge of rust-lang#70563 - GuillaumeGomez:page-hash-handling, …
99fc337 
…r=ollie27,kinnison

[rustdoc] Page hash handling

Fixes rust-lang#70476

A good example to see the change is to use this URL: https://doc.rust-lang.org/nightly/std/string/struct.String.html#from_iter.v-3

After the change, it actually goes to the target element (and change the page hash to something more clear for the users).

r? @kinnison

cc @ollie27
@bors bors closed this as completed in 218d96e Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[rustdoc] Page hash handling GuillaumeGomez/rust
2 participants
@antoyo @GuillaumeGomez