You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
mir-opt tests have a diff mode where the changes of a specific optimization are shown as a .diff file which is rendered as a diff by most tools. For 32/64 bit tests we ended up adding a postfix to the file name (which comes after the .diff), and that breaks the tool support. We should change all these tests file-names so they end with .diff again.
Do not do the last step before having run --bless, otherwise you'll have to figure out what files to rename and do it manually. This way you get --bless to do it for you.
cc @rust-lang/wg-mir-opt
The text was updated successfully, but these errors were encountered:
oli-obk
added
E-easy
Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
A-mir-opt
Area: MIR optimizations
labels
Aug 20, 2020
mir-opt tests have a
diff
mode where the changes of a specific optimization are shown as a.diff
file which is rendered as a diff by most tools. For32/64
bit tests we ended up adding a postfix to the file name (which comes after the.diff
), and that breaks the tool support. We should change all these tests file-names so they end with.diff
again.We should change both
rust/src/tools/compiletest/src/runtest.rs
Line 3172 in 5fff382
rust/src/tools/compiletest/src/runtest.rs
Line 3190 in 5fff382
bitsize
before the.diff
or.mir
respectively.After you've run
--bless
for both 32 bit and 64 bit, you also need to changerust/src/tools/compiletest/src/runtest.rs
Line 3147 in 5fff382
rust/src/tools/compiletest/src/runtest.rs
Line 3152 in 5fff382
Do not do the last step before having run
--bless
, otherwise you'll have to figure out what files to rename and do it manually. This way you get--bless
to do it for you.cc @rust-lang/wg-mir-opt
The text was updated successfully, but these errors were encountered: