Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Mention rust-analyzer maintainers when proc_macro bridge is changed" #101418

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

jonas-schievink
Copy link
Contributor

Reverts #99183

rust-analyzer is now a subtree, and CI fails when the proc_macro bridge changes break our tests, so these notifications aren't needed anymore.

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 4, 2022
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 4, 2022

📌 Commit f5cd223 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 4, 2022
@jonas-schievink
Copy link
Contributor Author

cc @rust-lang/wg-rls-2 for visibility

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 5, 2022
…mention-r-a, r=Mark-Simulacrum

Revert "Mention rust-analyzer maintainers when `proc_macro` bridge is changed"

Reverts rust-lang#99183

rust-analyzer is now a subtree, and CI fails when the `proc_macro` bridge changes break our tests, so these notifications aren't needed anymore.
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Sep 5, 2022
…mention-r-a, r=Mark-Simulacrum

Revert "Mention rust-analyzer maintainers when `proc_macro` bridge is changed"

Reverts rust-lang#99183

rust-analyzer is now a subtree, and CI fails when the `proc_macro` bridge changes break our tests, so these notifications aren't needed anymore.
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 6, 2022
Rollup of 7 pull requests

Successful merges:

 - rust-lang#99291 (Add let else drop order tests)
 - rust-lang#101402 (Add a Machine hook for inline assembly)
 - rust-lang#101404 (Fix cleanup for uninitialized stdout)
 - rust-lang#101418 (Revert "Mention rust-analyzer maintainers when `proc_macro` bridge is changed")
 - rust-lang#101425 (Point at type parameter in plain path expr)
 - rust-lang#101426 (Don't duplicate file descriptors into stdio fds)
 - rust-lang#101447 (Remove generics_def_id_map from the resolver.)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c633b0a into master Sep 6, 2022
@bors bors deleted the revert-99183-proc_macro-mention-r-a branch September 6, 2022 02:45
@rustbot rustbot added this to the 1.65.0 milestone Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants