-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 7 pull requests #117180
Rollup of 7 pull requests #117180
Commits on Oct 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ff7bf79 - Browse repository at this point
Copy the full SHA ff7bf79View commit details -
Configuration menu - View commit details
-
Copy full SHA for b3cfd5b - Browse repository at this point
Copy the full SHA b3cfd5bView commit details -
Require target features to match exactly during inlining
In general it is not correct to inline a callee with a target features that are subset of the callee. Require target features to match exactly during inlining. The exact match could be potentially relaxed, but this would require identifying specific feature that are allowed to differ, those that need to match, and those that can be present in caller but not in callee. This resolves MIR part of rust-lang#116573. For other concerns with respect to the previous implementation also see areInlineCompatible in LLVM.
Configuration menu - View commit details
-
Copy full SHA for 011b260 - Browse repository at this point
Copy the full SHA 011b260View commit details
Commits on Oct 25, 2023
-
Configuration menu - View commit details
-
Copy full SHA for bc18509 - Browse repository at this point
Copy the full SHA bc18509View commit details -
Remove support for alias
-Z instrument-coverage
This flag was stabilized in rustc 1.60.0 as `-C instrument-coverage`, but the old unstable flag was kept around as an alias to ease migration.
Configuration menu - View commit details
-
Copy full SHA for 65b0f6a - Browse repository at this point
Copy the full SHA 65b0f6aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2334143 - Browse repository at this point
Copy the full SHA 2334143View commit details -
Work around the fact that
check_mod_type_wf
may spuriously return `……ErrorGuaranteed`, even if that error is only emitted by `check_modwitem_types`
Configuration menu - View commit details
-
Copy full SHA for beaf46f - Browse repository at this point
Copy the full SHA beaf46fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 32339f8 - Browse repository at this point
Copy the full SHA 32339f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for a9fad1c - Browse repository at this point
Copy the full SHA a9fad1cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 268ec72 - Browse repository at this point
Copy the full SHA 268ec72View commit details -
Rollup merge of rust-lang#117111 - Zalathar:zinstrument, r=compiler-e…
…rrors Remove support for alias `-Z instrument-coverage` This flag was stabilized in rustc 1.60.0 (2022-04-07) as `-C instrument-coverage`, but the old unstable flag was kept around (with a warning) as an alias to ease migration. It should now be reasonable to remove the somewhat tricky code that implemented that alias. Fixes rust-lang#116980.
Configuration menu - View commit details
-
Copy full SHA for 24254d2 - Browse repository at this point
Copy the full SHA 24254d2View commit details -
Rollup merge of rust-lang#117141 - tmiasko:inline-target-features, r=…
…oli-obk Require target features to match exactly during inlining In general it is not correct to inline a callee with a target features that are subset of the callee. Require target features to match exactly during inlining. The exact match could be potentially relaxed, but this would require identifying specific feature that are allowed to differ, those that need to match, and those that can be present in caller but not in callee. This resolves MIR part of rust-lang#116573. For other concerns with respect to the previous implementation also see areInlineCompatible in LLVM.
Configuration menu - View commit details
-
Copy full SHA for a1ab167 - Browse repository at this point
Copy the full SHA a1ab167View commit details -
Rollup merge of rust-lang#117152 - compiler-errors:no-ret-coercion, r…
…=chenyukang Fix unwrap suggestion for async fn Use `body_fn_sig` to get the expected return type of the function instead of `ret_coercion` in `FnCtxt`. This avoids accessing the `ret_coercion` when it's already mutably borrowed (e.g. when checking `return` expressions). Fixes rust-lang#117144 r? `@chenyukang`
Configuration menu - View commit details
-
Copy full SHA for 585a122 - Browse repository at this point
Copy the full SHA 585a122View commit details -
Rollup merge of rust-lang#117154 - Dirreke:csky-unknown-linux-gunabiv…
…2, r=bjorn3 implement C ABI lowering for CSKY fix rust-lang/compiler-builtins#551 Reference: [CSKY ABI Manual](https://occ-oss-prod.oss-cn-hangzhou.aliyuncs.com/resource//1695027452256/T-HEAD_800_Series_ABI_Standards_Manual.pdf) Reference: [Clang CSKY lowering code](https://github.com/llvm/llvm-project/blob/4a074f32a6914f2a8d7215d78758c24942dddc3d/clang/lib/CodeGen/Targets/CSKY.cpp#L76-L162) r? `@bjorn3`
Configuration menu - View commit details
-
Copy full SHA for 74c2b98 - Browse repository at this point
Copy the full SHA 74c2b98View commit details -
Rollup merge of rust-lang#117159 - oli-obk:error_shenanigans, r=estebank
Work around the fact that `check_mod_type_wf` may spuriously return `ErrorGuaranteed` Even if that error is only emitted by `check_mod_item_types`. fixes rust-lang#117153 A cleaner refactoring would merge/chain these queries in ways that ensure we only actually get an `ErrorGuaranteed` if there was an error emitted.
Configuration menu - View commit details
-
Copy full SHA for 26a9e08 - Browse repository at this point
Copy the full SHA 26a9e08View commit details -
Rollup merge of rust-lang#117163 - tmiasko:compiletest-mir-opt, r=com…
…piler-errors compiletest: Display compilation errors in mir-opt tests Previously when compilation failed the `check_mir_dump` would panic first, so we would never display the compiler output.
Configuration menu - View commit details
-
Copy full SHA for beba522 - Browse repository at this point
Copy the full SHA beba522View commit details -
Rollup merge of rust-lang#117173 - oli-obk:gen_fn_split2, r=compiler-…
…errors Make `Iterator` a lang item r? `@compiler-errors` pulled out of rust-lang#116447 We're doing this change on its own, because iterator was the one diagnostic item that was load bearing on us correctly emitting errors about `diagnostic_item` mis-uses. It was used in some diagnostics as an early abort, before the actual checks of the diagnostic, so effectively the compiler was *unconditionally* checking for the iterator diagnostic item, even if it didn't emit any diagnostics. Changing those uses to use the lang item, caused us not to invoke the `all_diagnostic_items` query anymore, which then caused us to miss some issues around diagnostic items until they were actually used. The reason we keep the diagnostic item around is that clippy uses it a lot and having `Iterator` be a lang item and a diagnostic item at the same time doesn't cost us anything, but makes clippy's internal code simpler
Configuration menu - View commit details
-
Copy full SHA for b0521fe - Browse repository at this point
Copy the full SHA b0521feView commit details