Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API docs/examples for std::slice #16417

Merged
merged 1 commit into from
Aug 12, 2014
Merged

API docs/examples for std::slice #16417

merged 1 commit into from
Aug 12, 2014

Conversation

jasonthompson
Copy link
Contributor

  • Moved examples for permutations and next into trait definition as
    comments on pull request API docs/examples for std::slice #16244.
  • Fixed (hopefully) issue with erronious commit of changes to src/llvm.

 - API doc/example for next() in Permutations
 - API doc/example for permutations() in ImmutableCloneableVector
 - Moved examples for permutations and next into trait definition as
   comments on pull request #16244.
 - Fix erroneus inclusion of src/llvm in older commit.
@jasonthompson
Copy link
Contributor Author

@alexcrichton: Responding to your comments on my pull request last week. I've been fighting a bit with git, so hopefuly this works without causing too man issues. My work with git has been limited to smaller projects so far, so I'm somewhat of a noob.

@alexcrichton
Copy link
Member

No worries! Learning git is always a fun and exciting adventure filled with tears, misery, joy, and git reflog. This looks good to me now, thanks again!

bors added a commit that referenced this pull request Aug 12, 2014
- Moved examples for permutations and next into trait definition as
   comments on pull request #16244.
- Fixed (hopefully) issue with erronious commit of changes to src/llvm.
@bors bors closed this Aug 12, 2014
@bors bors merged commit 371e8cf into rust-lang:master Aug 12, 2014
matthiaskrgr pushed a commit to matthiaskrgr/rust that referenced this pull request Feb 5, 2024
…Veykril

feat: "Normalize import" assist and utilities for normalizing use trees

- Add import/use tree normalization utilities
- Add "normalize import" assist
- Update "merge imports" assist to always apply to the covering use item except for nested use tree selections
- Update "merge imports" assist to avoid adding unnecessary braces when merging nested use tree selections

See [this discussion](rust-lang/rust-analyzer#16372 (comment)) for the motivation for the new "normalize import" assist and changes to the "merge imports" assist.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants