Stabilize std::convert and related code
#23875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| reason = "waiting on RFC revision")] | ||
| fn as_slice(&self) -> &[T] { | ||
| self | ||
| } |
There was a problem hiding this comment.
This shouldn't be necessary, right? If we only intend to call this as a method it should be callable through an inherent method on [T]?
aturon
force-pushed
the
revise-convert-2
branch
2 times, most recently
from
4c52255
to
244c7e7
Compare
|
r=me with an unstable |
aturon
force-pushed
the
revise-convert-2
branch
from
244c7e7
to
1de815f
Compare
* Marks `#[stable]` the contents of the `std::convert` module.
* Added methods `PathBuf::as_path`, `OsString::as_os_str`,
`String::as_str`, `Vec::{as_slice, as_mut_slice}`.
* Deprecates `OsStr::from_str` in favor of a new, stable, and more
general `OsStr::new`.
* Adds unstable methods `OsString::from_bytes` and `OsStr::{to_bytes,
to_cstring}` for ergonomic FFI usage.
[breaking-change]
aturon
force-pushed
the
revise-convert-2
branch
from
1de815f
to
9fc51ef
Compare
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Mar 31, 2015
* Marks `#[stable]` the contents of the `std::convert` module.
* Added methods `PathBuf::as_path`, `OsString::as_os_str`,
`String::as_str`, `Vec::{as_slice, as_mut_slice}`.
* Deprecates `OsStr::from_str` in favor of a new, stable, and more
general `OsStr::new`.
* Adds unstable methods `OsString::from_bytes` and `OsStr::{to_bytes,
to_cstring}` for ergonomic FFI usage.
[breaking-change]
r? @alexcrichton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#[stable]the contents of thestd::convertmodule.PathBuf::as_path,OsString::as_os_str,String::as_str,Vec::{as_slice, as_mut_slice}.OsStr::from_strin favor of a new, stable, and moregeneral
OsStr::new.OsString::from_bytesandOsStr::{to_bytes, to_cstring}for ergonomic FFI usage.[breaking-change]
r? @alexcrichton