Refactor misc. "pure data structures" into their own crate #24209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r+ with the nits about comments fixed |
nikomatsakis
force-pushed
the
refactor-unification
branch
2 times, most recently
from
1c4532f
to
ead4631
Compare
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Apr 10, 2015
…r=nrc I'm on a quest to slowly refactor a lot of the inference code. A first step for that is moving the "pure data structures" out so as to simplify what's left. This PR moves `snapshot_vec`, `graph`, and `unify` into their own crate (`librustc_data_structures`). They can then be unit-tested, benchmarked, etc more easily. As a benefit, I improved the performance of unification slightly on the benchmark I added vs the original code. r? @nrc
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Apr 10, 2015
…r=nrc I'm on a quest to slowly refactor a lot of the inference code. A first step for that is moving the "pure data structures" out so as to simplify what's left. This PR moves `snapshot_vec`, `graph`, and `unify` into their own crate (`librustc_data_structures`). They can then be unit-tested, benchmarked, etc more easily. As a benefit, I improved the performance of unification slightly on the benchmark I added vs the original code. r? @nrc
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Apr 10, 2015
…r=nrc I'm on a quest to slowly refactor a lot of the inference code. A first step for that is moving the \"pure data structures\" out so as to simplify what's left. This PR moves `snapshot_vec`, `graph`, and `unify` into their own crate (`librustc_data_structures`). They can then be unit-tested, benchmarked, etc more easily. As a benefit, I improved the performance of unification slightly on the benchmark I added vs the original code. r? @nrc
|
☔ The latest upstream changes (presumably #24177) made this pull request unmergeable. Please resolve the merge conflicts. |
|
🔒 Merge conflict |
interface since in practice no delegates had any state.
older `each` method, but is otherwise identical.
but is otherwise mostly the same.
nikomatsakis
force-pushed
the
refactor-unification
branch
from
ead4631
to
e47fb48
Compare
|
Side discussion: Should |
bors
added a commit
that referenced
this pull request
Apr 18, 2015
I'm on a quest to slowly refactor a lot of the inference code. A first step for that is moving the "pure data structures" out so as to simplify what's left. This PR moves `snapshot_vec`, `graph`, and `unify` into their own crate (`librustc_data_structures`). They can then be unit-tested, benchmarked, etc more easily. As a benefit, I improved the performance of unification slightly on the benchmark I added vs the original code. r? @nrc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm on a quest to slowly refactor a lot of the inference code. A first step for that is moving the "pure data structures" out so as to simplify what's left. This PR moves
snapshot_vec,graph, andunifyinto their own crate (librustc_data_structures). They can then be unit-tested, benchmarked, etc more easily. As a benefit, I improved the performance of unification slightly on the benchmark I added vs the original code.r? @nrc