Don't use skolemized parameters but rather fresh variables in coherence #24245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coherence. Skolemized parameters wind up preventing unification. Surprised we had no test for this! Fixes rust-lang#24241.
|
@bors r+ |
|
📌 Commit 8578fee has been approved by |
|
@bors rollup |
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Apr 10, 2015
…failure, r=pnkfelix Don't use skolemized parameters but rather fresh variables in coherence. Skolemized parameters wind up preventing unification. Surprised we had no test for this! Fixes rust-lang#24241. r? @pnkfelix
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Apr 10, 2015
…failure, r=pnkfelix Don't use skolemized parameters but rather fresh variables in coherence. Skolemized parameters wind up preventing unification. Surprised we had no test for this! Fixes rust-lang#24241. r? @pnkfelix
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Apr 10, 2015
…failure, r=pnkfelix Don't use skolemized parameters but rather fresh variables in coherence. Skolemized parameters wind up preventing unification. Surprised we had no test for this! Fixes rust-lang#24241. r? @pnkfelix
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Apr 10, 2015
…failure, r=pnkfelix Don't use skolemized parameters but rather fresh variables in coherence. Skolemized parameters wind up preventing unification. Surprised we had no test for this! Fixes rust-lang#24241. r? @pnkfelix
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Apr 10, 2015
…failure, r=pnkfelix Don't use skolemized parameters but rather fresh variables in coherence. Skolemized parameters wind up preventing unification. Surprised we had no test for this! Fixes rust-lang#24241. r? @pnkfelix
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Apr 10, 2015
…failure, r=pnkfelix Don't use skolemized parameters but rather fresh variables in coherence. Skolemized parameters wind up preventing unification. Surprised we had no test for this! Fixes rust-lang#24241. r? @pnkfelix
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Apr 10, 2015
…failure, r=pnkfelix Don't use skolemized parameters but rather fresh variables in coherence. Skolemized parameters wind up preventing unification. Surprised we had no test for this! Fixes rust-lang#24241. r? @pnkfelix
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Apr 10, 2015
…failure, r=pnkfelix Don't use skolemized parameters but rather fresh variables in coherence. Skolemized parameters wind up preventing unification. Surprised we had no test for this! Fixes rust-lang#24241. r? @pnkfelix
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Apr 11, 2015
…failure, r=pnkfelix Don't use skolemized parameters but rather fresh variables in coherence. Skolemized parameters wind up preventing unification. Surprised we had no test for this! Fixes rust-lang#24241. r? @pnkfelix
bors
added a commit
that referenced
this pull request
Apr 14, 2015
r? @steveklabnik Should land this, #24270, and #24245 before rolling another beta.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't use skolemized parameters but rather fresh variables in coherence. Skolemized parameters wind up preventing unification. Surprised we had no test for this! Fixes #24241.
r? @pnkfelix