Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Debug impl for RangeFull #24491

Merged
merged 1 commit into from
Apr 17, 2015
Merged

Fix Debug impl for RangeFull #24491

merged 1 commit into from
Apr 17, 2015

Conversation

bluss
Copy link
Member

@bluss bluss commented Apr 16, 2015

Fix Debug impl for RangeFull

The Debug impl was using quotes, which was inconsistent:

=> (.., 1.., 2..3, ..4)
("..", 1.., 2..3, ..4)

Fix to use just ..

The Debug impl was using quotes, which was inconsistent:

    => (.., 1.., 2..3, ..4)
    ("..", 1.., 2..3, ..4)

Fix to use just ..
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @huonw (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@huonw
Copy link
Member

huonw commented Apr 16, 2015

@bors r+

@bors
Copy link
Contributor

bors commented Apr 16, 2015

📌 Commit 709b5e8 has been approved by huonw

Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 17, 2015
 Fix Debug impl for RangeFull

The Debug impl was using quotes, which was inconsistent:

    => (.., 1.., 2..3, ..4)
    (\"..\", 1.., 2..3, ..4)

Fix to use just ..
Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 17, 2015
 Fix Debug impl for RangeFull

The Debug impl was using quotes, which was inconsistent:

    => (.., 1.., 2..3, ..4)
    (\"..\", 1.., 2..3, ..4)

Fix to use just ..
Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 17, 2015
 Fix Debug impl for RangeFull

The Debug impl was using quotes, which was inconsistent:

    => (.., 1.., 2..3, ..4)
    (\"..\", 1.., 2..3, ..4)

Fix to use just ..
@bors bors merged commit 709b5e8 into rust-lang:master Apr 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants