Implement better object defaults (RFC #1156) #26370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikomatsakis
force-pushed
the
better-object-defaults-warn
branch
2 times, most recently
from
aabe806
to
325f468
Compare
|
I went ahead and made the warning more targeted. It was bugging me. |
|
cc me |
nikomatsakis
force-pushed
the
better-object-defaults-warn
branch
from
ee09ce4
to
b4bbc66
Compare
nikomatsakis
changed the title
|
RFC is merged. |
|
☔ The latest upstream changes (presumably #24527) made this pull request unmergeable. Please resolve the merge conflicts. |
nikomatsakis
force-pushed
the
better-object-defaults-warn
branch
from
b4bbc66
to
9b55ed3
Compare
nikomatsakis
added
the
beta-nominated
|
@pnkfelix ping (I'll rebase on Fri at the latest...) |
|
@nikomatsakis okay it all looks good to me, sorry it took me so long to get around to it. |
nikomatsakis
force-pushed
the
better-object-defaults-warn
branch
from
fc1731a
to
0ab544a
Compare
region-bound is expected to change in Rust 1.3, but don't use it for anything in this commit. Note that this is not a "significant" part of the type (it's not part of the formal model) so we have to normalize this away or trans starts to get confused because two equal types wind up with distinct LLVM types.
bound that is likely to change. In that case, it will change to 'static, so then scan down the graph to see whether there are any hard constraints that would prevent 'static from being a valid value here. Report a warning.
nikomatsakis
force-pushed
the
better-object-defaults-warn
branch
from
0ab544a
to
db5f3bc
Compare
nikomatsakis
added
the
beta-accepted
|
marks as beta-accepted |
|
@bors r+ p=1 |
|
📌 Commit db5f3bc has been approved by |
bors
added a commit
that referenced
this pull request
Jul 4, 2015
…komatsakis This is an implementation of RFC rust-lang/rfcs#1156. It includes the code to implement the new rules, but that code is currently disabled. It also includes code to issue warnings when the change will cause breakage. These warnings try hard to be targeted but are also somewhat approximate. They could, with some effort, be made *more* targeted by adjusting the code in ty_relate that propagates the "will change" flag to consider the specific operation. Might be worth doing. r? @pnkfelix (I think you understand region inference best)
This was referenced Jul 6, 2015
alexcrichton
removed
the
beta-nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation of RFC rust-lang/rfcs#1156. It includes the code to implement the new rules, but that code is currently disabled. It also includes code to issue warnings when the change will cause breakage. These warnings try hard to be targeted but are also somewhat approximate. They could, with some effort, be made more targeted by adjusting the code in ty_relate that propagates the "will change" flag to consider the specific operation. Might be worth doing.
r? @pnkfelix (I think you understand region inference best)