rustc: Swap link order of native libs/rust deps #28605
Conversation
|
r? @pcwalton (rust_highfive has picked a reviewer for you, use r? to override) |
|
r? @brson To be clear, this is going to be a breaking change (as evidenced by the test case that needed to be removed), but I also believe this is a bug fix to correct the test case that was added (e.g. that should definitely work). If we decide to move forward then this should certainly be mentioned in the release notes, and I can write up a longer explanation about what errors might show up and how to fix them. |
brson
added
the
relnotes
|
Should we crater this? Sounds frightening. |
|
@brson Yes. Ok, I'll do it. |
|
Still running. |
|
@bors r+ |
|
📌 Commit 0acd11e has been approved by |
|
⌛ Testing commit 0acd11e with merge baf8021... |
|
💔 Test failed - auto-linux-64-x-android-t |
alexcrichton
force-pushed
the
link-native-first
branch
from
0acd11e
to
27f0c78
Compare
|
@bors: r=brson 27f0c78 |
|
⌛ Testing commit 27f0c78 with merge 26a1df3... |
|
💔 Test failed - auto-linux-64-x-android-t |
This commit swaps the order of linking local native libraries and upstream native libraries on the linker command line. Detail of bugs this can cause can be found in rust-lang#28595, and this change also invalidates the test case that was added for rust-lang#12446 which is now considered a bug because the downstream dependency would need to declare that it depends on the native library somehow. Closes rust-lang#28595
alexcrichton
force-pushed
the
link-native-first
branch
from
27f0c78
to
9502df5
Compare
|
⌛ Testing commit 9502df5 with merge 587be42... |
This commit swaps the order of linking local native libraries and upstream native libraries on the linker command line. Detail of bugs this can cause can be found in #28595, and this change also invalidates the test case that was added for #12446 which is now considered a bug because the downstream dependency would need to declare that it depends on the native library somehow. Closes #28595 [breaking-change]
|
@larsbergstrom fyi |
|
Indeed thanks @Ms2ger! I'll also cc @metajack, and I've created a post on internals about this change to help get ahead of any surprising breakage. |
This commit swaps the order of linking local native libraries and upstream
native libraries on the linker command line. Detail of bugs this can cause can
be found in #28595, and this change also invalidates the test case that was
added for #12446 which is now considered a bug because the downstream dependency
would need to declare that it depends on the native library somehow.
Closes #28595
[breaking-change]