Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Any for unsized types #30928

Merged
merged 1 commit into from
Jan 17, 2016
Merged

Implement Any for unsized types #30928

merged 1 commit into from
Jan 17, 2016

Conversation

sfackler
Copy link
Member

This is a bit weird since unsized types can't be used in trait objects,
but Any is also used as pure marker trait since Reflect isn't stable.
There are many cases (e.g. TypeMap) where all you need is a TypeId.

r? @aturon

This is a bit weird since unsized types can't be used in trait objects,
but Any is *also* used as pure marker trait since Reflect isn't stable.
There are many cases (e.g. TypeMap) where all you need is a TypeId.
@alexcrichton
Copy link
Member

I have a vague inkling that we intentionally didn't do this in the past, but trying to recall the reason as to why I have no idea. As a result I'd be fine with this, but would like another sign-off as well.

@aturon
Copy link
Member

aturon commented Jan 16, 2016

I don't think it was an intentional omission. @sfackler is right that we end up using Any as a marker.

@bors: r+

@bors
Copy link
Contributor

bors commented Jan 16, 2016

📌 Commit 5d2275d has been approved by aturon

@bors
Copy link
Contributor

bors commented Jan 16, 2016

⌛ Testing commit 5d2275d with merge 41589a8...

@bors
Copy link
Contributor

bors commented Jan 16, 2016

💔 Test failed - auto-mac-64-nopt-t

@alexcrichton
Copy link
Member

@bors: retry

On Sat, Jan 16, 2016 at 12:20 AM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-mac-64-nopt-t
http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/7728


Reply to this email directly or view it on GitHub
#30928 (comment).

@bors
Copy link
Contributor

bors commented Jan 17, 2016

⌛ Testing commit 5d2275d with merge 21b8880...

@bors
Copy link
Contributor

bors commented Jan 17, 2016

💔 Test failed - auto-linux-64-nopt-t

@sfackler
Copy link
Member Author

@bors: retry

@bors
Copy link
Contributor

bors commented Jan 17, 2016

⌛ Testing commit 5d2275d with merge 373bc01...

@bors
Copy link
Contributor

bors commented Jan 17, 2016

💔 Test failed - auto-linux-64-nopt-t

@sfackler
Copy link
Member Author

@bors: retry

@bors
Copy link
Contributor

bors commented Jan 17, 2016

⌛ Testing commit 5d2275d with merge 8760874...

bors added a commit that referenced this pull request Jan 17, 2016
This is a bit weird since unsized types can't be used in trait objects,
but Any is *also* used as pure marker trait since Reflect isn't stable.
There are many cases (e.g. TypeMap) where all you need is a TypeId.

r? @aturon
@bors bors merged commit 5d2275d into rust-lang:master Jan 17, 2016
@brson brson added the relnotes Marks issues that should be documented in the release notes of the next release. label Jan 21, 2016
@sfackler sfackler deleted the any-unsized branch March 6, 2016 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes Marks issues that should be documented in the release notes of the next release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants