Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing refcell ref/refmut coercions to unsized #32652

Merged
merged 1 commit into from
Apr 2, 2016
Merged

Added missing refcell ref/refmut coercions to unsized #32652

merged 1 commit into from
Apr 2, 2016

Conversation

VFLashM
Copy link
Contributor

@VFLashM VFLashM commented Mar 31, 2016

Ref/RefMut should be coercible to unsized.
This commit adds a unit test and two missing CoerceUnsized implementations.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

Thanks! Could you actually change the stability to #[stable] since 1.9.0?

@VFLashM
Copy link
Contributor Author

VFLashM commented Mar 31, 2016

Sure!
Are CoerceUnsized/Unsize to be stabilized in 1.9?
I can't see anything about it in the codebase.
As far as I can tell all other coercions are still marked as unstable.

@alexcrichton
Copy link
Member

Oh right I guess the traits are unstable anyway, may as well stick to the same conventions as elsewhere!

@bors: r+ 33db2d6

@Manishearth Manishearth mentioned this pull request Apr 1, 2016
Merged
Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 1, 2016
@Manishearth
Rollup merge of rust-lang#32652 - VFLashM:refcell_ref_coercion, r=ale…
cf0a01a 
…xcrichton

Added missing refcell ref/refmut coercions to unsized

Ref/RefMut should be coercible to unsized.
This commit adds a unit test and two missing CoerceUnsized implementations.
bors added a commit that referenced this pull request Apr 2, 2016
@bors
Auto merge of #32666 - Manishearth:rollup, r=Manishearth
18172d1 
Rollup of 11 pull requests

- Successful merges: #32622, #32629, #32640, #32641, #32642, #32645, #32647, #32649, #32652, #32654, #32656
- Failed merges:
@bors bors merged commit 33db2d6 into rust-lang:master Apr 2, 2016
@brson brson added the relnotes Marks issues that should be documented in the release notes of the next release. label Apr 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brson brson

Labels
relnotes Marks issues that should be documented in the release notes of the next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@VFLashM @rust-highfive @alexcrichton @brson @bors