rustdoc: Cleanup ABI rendering

[ollie27]

Use a common method for rendering extern "<abi>".

This now consistently shows extern fn rather than extern "C" fn.

[rust-highfive]

r? @steveklabnik

(rust_highfive has picked a reviewer for you, use r? to override)

[alexcrichton]

I personally prefer showing extern fn wherever possible as the "C" is just redundant and doesn't need to get typed

[ollie27]

rustfmt adds "C" by default and I think it's worth being consistent with that.

[alexcrichton]

I agree that the two should be consistent, but I would personally consider rustfmt as the one that should change in this regard.

[alexcrichton]

cc @rust-lang/tools

[ollie27]

It was discussed here: rust-lang/rustfmt#451.

[alexcrichton]

Looks like rustfmt changed to elide "C"?

[mitaa]

Seems like the default for force_explicit_abi is set to true.
https://github.com/rust-lang-nursery/rustfmt/pull/950/files#diff-6d8a5e2104954a026de2bfe2b936aea4R331

[nrc]

I've been meaning to canvas opinions on what rustfmt should do here. I don't have a strong opinion.

[steveklabnik]

I used to put it in, but lately have switched to taking it out. I don't feel super strongly but would lean towards not including it.

On Apr 23, 2016, 12:21 +0300, Nick Cameronnotifications@github.com, wrote:

I've been meaning to canvas opinions on what rustfmt should do here. I don't have a strong opinion.

—
You are receiving this because you were mentioned.
Reply to this email directly orview it on GitHub(#33151 (comment))

[steveklabnik]

So, what is the conclusion here? That we're not going to merge this?

[ollie27]

I can change this to hide the "C" if that's what people want. After this patch changing it is only a one line change (+ fixing tests) anyway.

The point of this patch was consistency as rustdoc currently uses both styles in different places. For example https://doc.rust-lang.org/1.8.0/libc/fn.atexit.html has both on the same line.

[steveklabnik]

Ah, right, sorry. Consistency is certainly good.

On Apr 26, 2016, 11:32 -0400, Oliver Middletonnotifications@github.com, wrote:

I can change this to hide the"C"if that's what people want. After this patch changing it is only a one line change (+ fixing tests) anyway.

The point of this patch was consistency as rustdoc currently uses both styles in different places. For examplehttps://doc.rust-lang.org/1.8.0/libc/fn.atexit.htmlhas both on the same line.

—
You are receiving this because you were mentioned.
Reply to this email directly orview it on GitHub(#33151 (comment))

[alexcrichton]

Yeah I'd be fine with just removing the rendering of "C" elsewhere

[ollie27]

I've removed the "C".

[alexcrichton]

@bors: r+ 48aabbd

Thanks @ollie27

[bors]

⌛ Testing commit 48aabbd with merge cf3970a...

[bors]

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-32cross-opt, auto-linux-64-cargotest, auto-linux-64-cross-armhf, auto-linux-64-cross-armsf, auto-linux-64-cross-freebsd, auto-linux-64-cross-netbsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-cross-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir, auto-win-msvc-64-opt-rustbuild