Rename main thread from "<main>" to "main". #33803
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
| @@ -221,15 +221,15 @@ If you add a main function that calls `diverges()` and run it, you’ll get | |||
| some output that looks like this: | |||
|
|
|||
| ```text | |||
| thread ‘<main>’ panicked at ‘This function never returns!’, hello.rs:2 | |||
| thread ‘main’ panicked at ‘This function never returns!’, hello.rs:2 | |||
There was a problem hiding this comment.
Unrelated to this change specifically, but it looks like some smart quotes snuck into this line.
alexcrichton
added
the
T-libs-api
alexcrichton
added
the
relnotes
|
The libs team discussed this during triage the other day and there wasn't necessarily a strong consensus either way, but there were some who did want this change. I did some digging as I was curious about the historical context here. The name Given all that I think there's no reason that this is the way it is, it's just carrying pieces forward. I'm gonna go ahead and r+ as we're early in the next cycle, but @brson I suspect will surely have an opinion on this as well (he's currently out on vacation), so we may revisit in the next few weeks as well. Thanks for the PR @WiSaGaN! |
|
⌛ Testing commit 226bcdf with merge ffa6a90... |
|
💔 Test failed - auto-win-msvc-64-cargotest |
|
There are two tests in But I guess test failure between merging this pull request and cargo-2747 is not avoidable? |
Rename main thread from '<main>' to 'main'. This pull request resolves the test failure in rust pull request 33803 rust-lang/rust#33803
|
sgtm @WiSaGaN to get cargo to pass you'll probably have to weaken the cargo tests so they don't care about the exact text; alternately disable the tests in cargo temporarily, land this PR, then reenable the tests in cargo with the new error string. |
|
Ah only those with r+ privs can currently approve PRs (or retry them). I think this'll need to update the rev of cargo in cargotest, however, or otherwise the new changes won't get pulled in by default. |
|
@alexcrichton Is there a policy of updating of cargo in cargotest? Or I can upgrade it as another commit in this pull-request? |
|
Ah you'll have to upgrade it in this PR to land it, so it's fine to just roll it into here. Either as a separate commit or as one of the previous is fine. |
|
There is some problem in CI preventing the update. |
Fix issue #33789
We may need to discuss whether this counts as a breaking change since code may check the main thread name against "
". Discussion is in #33789