Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update E0070 to new error format #35615

Merged
merged 1 commit into from
Aug 15, 2016
Merged

Update E0070 to new error format #35615

merged 1 commit into from
Aug 15, 2016

Conversation

clementmiao
Copy link
Contributor

@clementmiao clementmiao commented Aug 12, 2016

Updated E0070 to new error format.
Part of #35233
Fixes #35503

Thanks for letting me help!

r? @jonathandturner

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Aatch (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@clementmiao
Copy link
Contributor Author

closed for now, need to fix the unit tests.

@clementmiao clementmiao reopened this Aug 12, 2016
@clementmiao
Copy link
Contributor Author

Fixing tidy error

@sophiajt
Copy link
Contributor

Thanks for the PR!

Can you do squash your 3 commits down to 1 commit? With that, I think we're good.

@clementmiao
Copy link
Contributor Author

Thanks Jonathan, just squashed them into 1! @jonathandturner

@sophiajt
Copy link
Contributor

Great! Looks good.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 12, 2016

📌 Commit 4ab00e4 has been approved by jonathandturner

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 13, 2016
… r=jonathandturner

Update E0070 to new error format

Updated E0070 to new error format.
Part of rust-lang#35233
Fixes rust-lang#35503

Thanks for letting me help!

r? @jonathandturner
eddyb added a commit to eddyb/rust that referenced this pull request Aug 14, 2016
… r=jonathandturner

Update E0070 to new error format

Updated E0070 to new error format.
Part of rust-lang#35233
Fixes rust-lang#35503

Thanks for letting me help!

r? @jonathandturner
eddyb added a commit to eddyb/rust that referenced this pull request Aug 14, 2016
… r=jonathandturner

Update E0070 to new error format

Updated E0070 to new error format.
Part of rust-lang#35233
Fixes rust-lang#35503

Thanks for letting me help!

r? @jonathandturner
bors added a commit that referenced this pull request Aug 14, 2016
@bors
Copy link
Contributor

bors commented Aug 15, 2016

☔ The latest upstream changes (presumably #35666) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors merged commit 4ab00e4 into rust-lang:master Aug 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants