Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update E0428 to new format #35831

Merged
merged 2 commits into from
Aug 20, 2016
Merged

Update E0428 to new format #35831

merged 2 commits into from
Aug 20, 2016

Conversation

trixnz
Copy link
Contributor

@trixnz trixnz commented Aug 19, 2016

Fixes #35798 as part of #35233.

r? @jonathandturner

@sophiajt
Copy link
Contributor

Looks good!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 19, 2016

📌 Commit 3b64cf6 has been approved by jonathandturner

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 19, 2016
@sophiajt
Copy link
Contributor

@bors r-

Looks like there are a couple more tests to update:


failures:
    [compile-fail] compile-fail\enum-and-module-in-same-scope.rs
    [compile-fail] compile-fail\issue-21546.rs
    [compile-fail] compile-fail\trait-duplicate-methods.rs

test result: FAILED. 2490 passed; 3 failed; 20 ignored; 0 measured

You should be able to check these with (possibly changing stage to 2 if this doesn't catch it):

python src/bootstrap/bootstrap.py --step check-cfail --stage 1

@trixnz
Copy link
Contributor Author

trixnz commented Aug 20, 2016

Looks like I was a little overzealous 😄. Should be fixed now.

@sophiajt
Copy link
Contributor

Thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 20, 2016

📌 Commit d791aa1 has been approved by jonathandturner

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 20, 2016
bors added a commit that referenced this pull request Aug 20, 2016
@bors bors merged commit d791aa1 into rust-lang:master Aug 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants