Rollup of 13 pull requests #36177
Merged
Rollup of 13 pull requests #36177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it possible to use it as key in various maps.
This is the augmented-assignment version of PR rust-lang#35809. r? @GuillaumeGomez improved documentation a la PR rust-lang#35993
Fixed E0259 unit test Added name of conflict to E0259's note
…urner Change E0259 to the new error format Fixes rust-lang#35514 as part of rust-lang#35233. Sorry about creating a new PR I was having a lot of troubles squashing the commit because I didn't properly branch the new feature. r? @GuillaumeGomez
…abnik Improve Path and PathBuf docs r? @steveklabnik
…crichton Implement more traits for `std::io::ErrorKind` This makes it possible to use it as key in various maps.
…, r=GuillaumeGomez replace `BitAndAssign` example with something more evocative This is the augmented-assignment version of PR rust-lang#35809. r? @GuillaumeGomez
…, r=steveklabnik Add missing urls into convert module r? @steveklabnik
fix git submodule status check None
Update E0393 to new error format Fixes rust-lang#35632. Part of rust-lang#35233. r? @jonathandturner and a wired thing is that if i add another label ```rust .span_label(span, &format!("missing reference to `{}`", def.name)) .span_label(span, &format!("because of the default `Self` reference, type parameters must be specified on object types")) ``` and add a new note in the test case like ```rust trait A<T=Self> {} fn together_we_will_rule_the_galaxy(son: &A) {} //~^ ERROR E0393 //~| NOTE missing reference to `T` //~| NOTE because of the default `Self` reference, type parameters must be specified on object types ``` it will complain that ``` running 1 test test [compile-fail] compile-fail/E0393.rs ... FAILED failures: ---- [compile-fail] compile-fail/E0393.rs stdout ---- error: /Users/zjh/Documents/rustspace/rust/src/test/compile-fail/E0393.rs:13: unexpected "error": '13:43: 13:44: the type parameter `T` must be explicitly specified [E0393]' unexpected errors (from JSON output): [ Error { line_num: 13, kind: Some( Error ), msg: "13:43: 13:44: the type parameter `T` must be explicitly specified [E0393]" } ] ``` it is a little bit confusing and through the blog post we can use `//~^` and `//~|` to support multiple notes, @jonathandturner am i missing something here?
… r=brson Fix the test_variadic_ptr fn on printf-less sys Fixes rust-lang#36076
…richton Unignore the json tests on 32-bit platforms cc rust-lang#14064 r? @alexcrichton
…chton Fix run-pass/signal-exit-status to not trigger UB by writing to NULL. `run-pass/signal-exit-status` has had UB (NULL dereference) since it was introduced in rust-lang#10109. Fixes the test failure found by @camlorn while running under Windows Subsystem for Linux.
Update man pages Until I finish rust-lang#35438
…komatsakis Change 'rustc::plugin' to 'rustc_plugin' in doc comment It looks like there is a missing one.
|
@bors r+ p=1 |
|
📌 Commit 5c97100 has been approved by |
|
(rust_highfive has picked a reviewer for you, use r? to override) |
bors
added a commit
that referenced
this pull request
Sep 1, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::io::ErrorKind#35911, replaceBitAndAssignexample with something more evocative #35927, Add missing urls into convert module #36083, Add test for #28324 #36087, fix git submodule status check #36098, Update E0393 to new error format #36114, Fix the test_variadic_ptr fn on printf-less sys #36118, Unignore the json tests on 32-bit platforms #36123, Fix run-pass/signal-exit-status to not trigger UB by writing to NULL. #36129, Update man pages #36152, Change 'rustc::plugin' to 'rustc_plugin' in doc comment #36169