Special case a few colors for Windows #36178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| try!(self.start_attr(term::Attr::ForegroundColor(term::color::BRIGHT_CYAN))); | ||
| } else { | ||
| try!(self.start_attr(term::Attr::ForegroundColor(term::color::BRIGHT_BLUE))); | ||
| } |
There was a problem hiding this comment.
Nit:
let fg_color = if cfg!(windows) {
term::color::BRIGHT_CYAN
} else {
term::color::BRIGHT_BLUE
};
try!(self.start_attr(term::Attr::ForegroundColor(fg_color)));There was a problem hiding this comment.
Or even
try!(self.start_attr(term::Attr::ForegroundColor(
if cfg!(windows) {
term::color::BRIGHT_CYAN
} else {
term::color::BRIGHT_BLUE
}
)));But these seem like pretty minor details?
There was a problem hiding this comment.
But these seem like pretty minor details?
Yep, hence the "Nit" ;)
|
For comparison, here's regular cyan:
|
|
Chatted with Niko on IRC, and sounds like we're good. r=him @bors r=nikomatsakis |
|
📌 Commit 1b04762 has been approved by |
|
@bors rollup |
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this pull request
Sep 2, 2016
…ikomatsakis Special case a few colors for Windows As brought up on [this thread](rust-lang#33240 (comment)) the colors used in error messages on Windows can be difficult to read because of the lack of bold. This PR makes a few changes to improve readability, namely: * Rather than using BRIGHT_BLUE, on Windows we now use BRIGHT_CYAN, which is easier to read on black when you do not have bold * We used BRIGHT_YELLOW rather than YELLOW, for the same reason * Titles will be BRIGHT_WHITE now, to give the illusion of being bold Some examples:   r? @nikomatsakis cc @retep998
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this pull request
Sep 2, 2016
…ikomatsakis Special case a few colors for Windows As brought up on [this thread](rust-lang#33240 (comment)) the colors used in error messages on Windows can be difficult to read because of the lack of bold. This PR makes a few changes to improve readability, namely: * Rather than using BRIGHT_BLUE, on Windows we now use BRIGHT_CYAN, which is easier to read on black when you do not have bold * We used BRIGHT_YELLOW rather than YELLOW, for the same reason * Titles will be BRIGHT_WHITE now, to give the illusion of being bold Some examples:   r? @nikomatsakis cc @retep998
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this pull request
Sep 2, 2016
…ikomatsakis Special case a few colors for Windows As brought up on [this thread](rust-lang#33240 (comment)) the colors used in error messages on Windows can be difficult to read because of the lack of bold. This PR makes a few changes to improve readability, namely: * Rather than using BRIGHT_BLUE, on Windows we now use BRIGHT_CYAN, which is easier to read on black when you do not have bold * We used BRIGHT_YELLOW rather than YELLOW, for the same reason * Titles will be BRIGHT_WHITE now, to give the illusion of being bold Some examples:   r? @nikomatsakis cc @retep998
upsuper
reviewed
Feb 1, 2017
| @@ -896,6 +900,9 @@ impl Destination { | |||
| } | |||
| Style::OldSchoolNoteText | Style::HeaderMsg => { | |||
| try!(self.start_attr(term::Attr::Bold)); | |||
| if cfg!(windows) { | |||
| try!(self.start_attr(term::Attr::ForegroundColor(term::color::BRIGHT_WHITE))); | |||
| } | |||
There was a problem hiding this comment.
Ah... This is annoying for me since I use console with white background on Windows. These messages are completely invisible there. (Windows uses black background by default... but I'm used to seeing white background...) I guess a solution would be to detect the console setting in libterm (probably via GetConsoleScreenBufferInfo), and only apply these Windows-specific cases when the background is black...
There was a problem hiding this comment.
If you want a white background, couldn't you just invert the brightness of all the colors so the background is "black" but "black" actually means white, and "bright_white" actually means black?
There was a problem hiding this comment.
OK, fair. I didn't know I can do that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As brought up on this thread the colors used in error messages on Windows can be difficult to read because of the lack of bold.
This PR makes a few changes to improve readability, namely:
Some examples:
r? @nikomatsakis
cc @retep998