rustdoc: Filter more incorrect methods inherited through Deref #36266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
| SelfTy::SelfBorrowed(_lifetime, mutability) => { | ||
| deref_mut_ || mutability == Mutability::Immutable | ||
| }, | ||
| SelfTy::SelfExplicit(_) => false, |
There was a problem hiding this comment.
This also matches things like self: &Self, self: &Foo, self: &mut Self, self: &mut Foo, self: Self and self: Foo which we don't want to remove.
Old code filtered out only static methods. This code also excludes &mut self methods if there is no DerefMut implementation
Sawyer47
force-pushed
the
issue-35169
branch
from
e05d8a4
to
915bbda
Compare
|
👍 Waiting for @steveklabnik's confirmation. |
|
Seems like a good idea to me, I wonder what alex thinks. |
bors
added a commit
that referenced
this pull request
Sep 7, 2016
rustdoc: Filter more incorrect methods inherited through Deref Old code filtered out only static methods. This code also excludes &mut self methods if there is no DerefMut implementation. Fixes #35169
bluss
added
the
relnotes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old code filtered out only static methods. This code also excludes &mut self methods if there is no DerefMut implementation.
Fixes #35169