Update E0049 to new error format #36383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| format!("{} type parameter", | ||
| num_trait_m_type_params) | ||
| })) | ||
| .span_label(span, &format!("but got {}", |
There was a problem hiding this comment.
Would probably read better here to follow the wording we have for other errors, something like "expected... , found..."
|
Commented on a few things to fix, mostly around making sure we keep the same wording and test the all the cases. |
GuillaumeGomez
force-pushed
the
e0049
branch
from
2e5458b
to
3558462
Compare
|
Updated. |
|
@bors r+ rollup |
|
📌 Commit 3558462 has been approved by |
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this pull request
Sep 15, 2016
…rner Update E0049 to new error format Fixes rust-lang#35210. Part of rust-lang#35233. r? @jonathandturner
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this pull request
Sep 16, 2016
…rner Update E0049 to new error format Fixes rust-lang#35210. Part of rust-lang#35233. r? @jonathandturner
bors
added a commit
that referenced
this pull request
Sep 16, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35210.
Part of #35233.
r? @jonathandturner