save_analysis: Dump data only if get_path_data doesn't fail to resolve a path. #37144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sadly, its a pain to test save-analysis in any meaningful way. If you wanted a follow-up thing to work on, you could add a version of the run-make smoke test that has an error in it so that we're at least testing the error case to some extent. |
nrc
reviewed
Oct 13, 2016
| scope: vrd.scope, | ||
| qualname: String::new() | ||
| }.lower(self.tcx)); | ||
| if let Some(path_data) = path_data { |
There was a problem hiding this comment.
Rather than an if let here, it is probably better to do an early return - I don't think we want to hit the following match statement and it means there is less rightward drift.
|
@bors: r+ rollup |
|
📌 Commit 88b031e has been approved by |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Oct 26, 2016
save_analysis: Dump data only if get_path_data doesn't fail to resolve a path. Solves rust-lang#37126 Dump data only if `get_path_data` doesn't fail to resolve a path. `get_path_data` returns `None` when it have to deals with `Def::Err`, which is used as placeholder for a failed resolution. Tell me if this is good enough, maybe I have to add some tests ? r? @nrc
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Oct 26, 2016
save_analysis: Dump data only if get_path_data doesn't fail to resolve a path. Solves rust-lang#37126 Dump data only if `get_path_data` doesn't fail to resolve a path. `get_path_data` returns `None` when it have to deals with `Def::Err`, which is used as placeholder for a failed resolution. Tell me if this is good enough, maybe I have to add some tests ? r? @nrc
bors
added a commit
that referenced
this pull request
Oct 26, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #37126
Dump data only if
get_path_datadoesn't fail to resolve a path.get_path_datareturnsNonewhen it have to deals withDef::Err, which is used as placeholder for a failed resolution.Tell me if this is good enough, maybe I have to add some tests ?
r? @nrc