Make all vec! macros use square brackets: Attempt 2 #37497
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nrc (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
This still has merge commits... |
|
There's a little checkbox you can check to allow the maintainers of this project to be able to update your PR for you, which would let them clean up your commit history for you. https://github.com/blog/2247-improving-collaboration-with-forks |
iirelu
force-pushed
the
proper-vec-brackets-2
branch
from
0e3ccdb
to
777af9e
Compare
|
Okay, I think I finally unfricked my commit history-- AW GOD DAMMIT |
Most of the Rust community agrees that the vec! macro is clearer when called using square brackets [] instead of regular brackets (). Most of these ocurrences are from before macros allowed using different types of brackets. There is one left unchanged in a pretty-print test, as the pretty printer still wants it to have regular brackets.
iirelu
force-pushed
the
proper-vec-brackets-2
branch
from
777af9e
to
e593c3b
Compare
|
After countless horrible force-pushes, history rewrites, and endless trial and error, I have finally tamed the beast known as git. Thanks so much to @steveklabnik for all the help! 💜 |
|
@bors: r+ p=1 Let's try to get this in the queue so it doesn't go out of date. |
|
📌 Commit e593c3b has been approved by |
|
(That is, I'll r- if Travis still fails for some reason.) |
Make all vec! macros use square brackets: Attempt 2 [The last PR](#37476) ended with tears after a valiant struggle with git. I managed to clean up the completely broken history of that into a brand spanking new PR! Yay! Original: > Everyone hates the old syntax. I hope. Otherwise this PR has some controversy I wasn't expecting. > This would be the perfect time to write a lint recommending vec![..] when you use another style. > Disclaimer: I may have broken something. If I have, I'll fix them when the tests come in. Luckily the chance for a non-syntactical error is pretty low in all this.
|
Well looks like @bors got to it before Travis, I'm sure it'll be fine 😄 |
|
Has there been a discussion why we prefer |
|
@WiSaGaN Because it matches array literal syntax which uses |
|
Seems it can go either way as |
|
Not all macros get called with On Mon, Oct 31, 2016 at 11:38 PM, Wangshan Lu notifications@github.com
|
The last PR ended with tears after a valiant struggle with git. I managed to clean up the completely broken history of that into a brand spanking new PR! Yay!
Original: