save-analysis: add signature info #38529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Occurs when we produce save-analysis before type checking is complete (due to errors).
|
(rust_highfive has picked a reviewer for you, use r? to override) |
nikomatsakis
approved these changes
Dec 22, 2016
| prev = tok; | ||
| continue; | ||
| } | ||
| if let TokenTree::Token(_, token::Semi) = tok { |
There was a problem hiding this comment.
out of curiosity, what will happen if part of this is generated by a macro ?
There was a problem hiding this comment.
Horrible failure. Pretty much any use of the span_utils module has to be guarded by checks for generated code. There are a couple of macros to help with that.
|
@bors r+ |
|
📌 Commit c24b192 has been approved by |
|
⌛ Testing commit c24b192 with merge e7ec3b3... |
|
💔 Test failed - auto-linux-32-nopt-t |
|
@bors: retry |
bors
added a commit
that referenced
this pull request
Dec 23, 2016
save-analysis: add signature info These 'signatures' for definitions contain enough info for the RLS to create Rustdoc-style info on the fly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These 'signatures' for definitions contain enough info for the RLS to create Rustdoc-style info on the fly.