[beta] rustbuild: Pass -fPIC on 32-bit non-Windows platforms #39667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a smaller and more targeted backport of rust-lang#39523 which drives to the heart of the issue, just passing `-fPIC` on 32-bit platforms. More rationale for this commit can be found in rust-lang#39523 itself.
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
|
alexcrichton
changed the title
|
@bors r+ |
|
📌 Commit 1784a1a has been approved by |
|
@bors: p=100 |
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a smaller and more targeted backport of #39523 which drives to the heart
of the issue, just passing
-fPICon 32-bit platforms. More rationale for thiscommit can be found in #39523 itself.