Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc: Whitelist the FMA target feature #40431

Merged
merged 1 commit into from
Mar 12, 2017
Merged

rustc: Whitelist the FMA target feature #40431

merged 1 commit into from
Mar 12, 2017

Conversation

fsasm
Copy link
Contributor

@fsasm fsasm commented Mar 10, 2017

This commit adds the entry "fma\0" to the whitelist for the x86
target. LLVM already supports fma but rustc did not directly. Previously
rustc permitted +fma in the target-feature argument and enabled the use
of FMA instructions, but it did not list it in the configuration and
attributes.

fixes #40406

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @eddyb (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@eddyb
Copy link
Member

eddyb commented Mar 10, 2017

cc @rust-lang/compiler @rust-lang/libs What's our policy here?

This commit adds the entry `"fma\0"` to the whitelist for the x86
target. LLVM already supports fma but rustc did not directly. Previously
rustc permitted `+fma` in the target-feature argument and enabled the use
of FMA instructions, but it did not list it in the configuration and
attributes.

fixes #40406
@BurntSushi
Copy link
Member

@eddyb We don't have a policy. We've just been kind of merging them as they come up.

@fsasm What are you using this for?

@fsasm
Copy link
Contributor Author

fsasm commented Mar 10, 2017

@BurntSushi I'm trying to add FMA support to the simd crate. Because FMA can improve precision I want to use it later for some scientific computations.

@BurntSushi
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Mar 10, 2017

📌 Commit 4d23ca4 has been approved by BurntSushi

arielb1 pushed a commit to arielb1/rust that referenced this pull request Mar 11, 2017
rustc: Whitelist the FMA target feature

This commit adds the entry `"fma\0"` to the whitelist for the x86
target. LLVM already supports fma but rustc did not directly. Previously
rustc permitted `+fma` in the target-feature argument and enabled the use
of FMA instructions, but it did not list it in the configuration and
attributes.

fixes rust-lang#40406
bors added a commit that referenced this pull request Mar 11, 2017
Rollup of 13 pull requests

- Successful merges: #40146, #40299, #40315, #40319, #40344, #40345, #40367, #40372, #40373, #40385, #40400, #40404, #40431
- Failed merges:
arielb1 pushed a commit to arielb1/rust that referenced this pull request Mar 11, 2017
rustc: Whitelist the FMA target feature

This commit adds the entry `"fma\0"` to the whitelist for the x86
target. LLVM already supports fma but rustc did not directly. Previously
rustc permitted `+fma` in the target-feature argument and enabled the use
of FMA instructions, but it did not list it in the configuration and
attributes.

fixes rust-lang#40406
bors added a commit that referenced this pull request Mar 12, 2017
Rollup of 12 pull requests

- Successful merges: #40146, #40299, #40315, #40319, #40344, #40345, #40372, #40373, #40400, #40404, #40419, #40431
- Failed merges:
@bors bors merged commit 4d23ca4 into rust-lang:master Mar 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'fma' is missing in target-feature
5 participants