Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: generic FromIterator and Extend Cow for String #41454

Closed
wants to merge 3 commits into from
Closed

WIP: generic FromIterator and Extend Cow for String #41454

wants to merge 3 commits into from

Conversation

Eh2406
Copy link
Contributor

@Eh2406 Eh2406 commented Apr 22, 2017

This is an extension of pr: #41449 to experiment with @jmesmon suggestions.

This is mostly to use the ci services. I will close after.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@Eh2406
Copy link
Contributor Author

Eh2406 commented Apr 22, 2017

Thanks for letting me use the ci to test the things that aren't going to work. Sorry for the noise.

@Eh2406 Eh2406 closed this Apr 22, 2017
@Eh2406 Eh2406 deleted the gen_herd_cows branch April 22, 2017 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants