Rollup of 15 pull requests #41539
Closed
Rollup of 15 pull requests #41539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also spell out that read and write operations should be retried on `ErrorKind::Interrupted` errors. Fixes rust-lang#38494.
Turns out all six of these impls are incorrect.
Suppress warning introduced by rust-lang/cargo#3841.
ASan and TSan are supported on macOS, and this commit enables their support. The sanitizers are always built as *.dylib on Apple platforms, so they cannot be statically linked into the corresponding `rustc_?san.rlib`. The dylibs are directly copied to `lib/rustlib/x86_64-apple-darwin/lib/` instead. Note, although Xcode also ships with their own copies of ASan/TSan dylibs, we cannot use them due to version mismatch. There is a caveat: the sanitizer libraries are linked as @rpath, so the user needs to additionally pass `-C rpath`: rustc -Z sanitizer=address -C rpath file.rs ^~~~~~~~ Otherwise there will be a runtime error: dyld: Library not loaded: @rpath/libclang_rt.asan_osx_dynamic.dylib Referenced from: /path/to/executable Reason: image not found Abort trap: 6 The next commit includes a temporary change in compiler to force the linker to emit a usable @rpath.
This commit sort of brings back rust-lang#40777 by upgrading back to 6.3.0. While investigating rust-lang#40546 it was discovered that 6.3.0 appears to not spurious fail in the same way that 6.2.0 does (which we're currently using). The workaround for rust-lang#40184 contained in rust-lang#40777 did not work so this commit also contains a different workaround for the gdb issue. We will not download the 6.2.0 version of gdb and use that instead of the default version that comes with 6.3.0. I'm going to optimistically say... Closes rust-lang#40546
With regards to the unstable book, the reference, and the processes involved. Also, fix up a link by pointing to the new tracking issue rather than the older one. Fixes rust-lang#41285
These are not even crates...
Adds rust-windbg.cmd script Adds rust-gdb/rust-lldb equivalent for windbg that loads the Rust .natvis files on start. This change modifies the bootstrap code to add rust-windbg to bin and the .natvis files to lib/rustlib/etc. Example usage from cmd or PowerShell: ``` rust-windbg -c "bu rs_f442289d74765418!rs::main;g" target\debug\rs.exe ```
…chton Support AddressSanitizer and ThreadSanitizer on x86_64-apple-darwin [ASan](https://clang.llvm.org/docs/AddressSanitizer.html#supported-platforms) and [TSan](https://clang.llvm.org/docs/ThreadSanitizer.html#supported-platforms) are supported on macOS, and this commit enables their support. The sanitizers are always built as `*.dylib` on Apple platforms, so they cannot be statically linked into the corresponding `rustc_?san.rlib`. The dylibs are directly copied to `lib/rustlib/x86_64-apple-darwin/lib/` instead. Note, although Xcode also ships with their own copies of ASan/TSan dylibs, we cannot use them due to version mismatch. ---- ~~There is a caveat: the sanitizer libraries are linked as `@rpath/` (due to https://reviews.llvm.org/D6018), so the user needs to additionally pass `-C rpath`:~~ **Edit:** Passing rpath is now automatic.
…richton Add bootstrap support for android
…enkov appveyor: Upgrade to gcc for mingw 6.3.0 This commit sort of brings back rust-lang#40777 by upgrading back to 6.3.0. While investigating rust-lang#40546 it was discovered that 6.3.0 appears to not spurious fail in the same way that 6.2.0 does (which we're currently using). The workaround for rust-lang#40184 contained in rust-lang#40777 did not work so this commit also contains a different workaround for the gdb issue. We will not download the 6.2.0 version of gdb and use that instead of the default version that comes with 6.3.0. I'm going to optimistically say... Closes rust-lang#40546
Specify behavior of `write_all` for `ErrorKind::Interrupted` errors Also spell out that read and write operations should be retried on `ErrorKind::Interrupted` errors. Fixes rust-lang#38494.
added 10 commits
April 25, 2017 17:35
Haiku: fix initial platform support
Add internal accessor methods to io::{Chain, Take}.
Resolves rust-lang#29067.
Step::replace_one should put a one, not a zero (Issue rust-lang#41492) Turns out all six of the replace_* impls were backwards.
use the word 'length' in Vec::len's docs Fixes rust-lang#37866
…ion, r=jseyfried Invalid module location Fixes rust-lang#38110. r? @jseyfried
Fix a copy-paste error in `Instant::sub_duration` Fixes rust-lang#41514.
Clean up TcpStream example Fixes rust-lang#35950
Clarify the doc index With regards to the unstable book, the reference, and the processes involved. Also, fix up a link by pointing to the new tracking issue rather than the older one. Fixes rust-lang#41285 r? @frewsxcv
Clarify "side effect" in peek's docs Fixes rust-lang#33269 /cc @tshepang
Fix up vec guarnatee around capacity Fixes rust-lang#37746 r? @rust-lang/libs
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ p=10 |
|
📌 Commit 8ccf0e8 has been approved by |
|
⌛ Testing commit 8ccf0e8 with merge e4170ed... |
|
💔 Test failed - status-appveyor |
|
AppVeyor failure due to #41420. Travis (PR) failure due to this error (#41526): |
|
☔ The latest upstream changes (presumably #41551) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
write_allforErrorKind::Interruptederrors #41442, Haiku: fix initial platform support #41456, Add internal accessor methods to io::{Chain, Take}. #41463, Step::replace_one should put a one, not a zero (Issue #41492) #41493, use the word 'length' in Vec::len's docs #41500, Invalid module location #41501, Fix a copy-paste error inInstant::sub_duration#41518, Clean up TcpStream example #41526, Clarify the doc index #41527, Clarify "side effect" in peek's docs #41528, Fix up vec guarnatee around capacity #41535