Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow variadic functions with cdecl calling convention. #42249

Merged
merged 1 commit into from
May 28, 2017

Conversation

Mark-Simulacrum
Copy link
Member

Fixes #40244.

@rust-highfive
Copy link
Collaborator

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@Mark-Simulacrum
Copy link
Member Author

cc @retep998

@eddyb
Copy link
Member

eddyb commented May 26, 2017

@bors r+

@bors
Copy link
Contributor

bors commented May 26, 2017

📌 Commit 35dd87f has been approved by eddyb

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 26, 2017
Allow variadic functions with cdecl calling convention.

Fixes rust-lang#40244.
@shepmaster shepmaster added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 27, 2017
@Mark-Simulacrum
Copy link
Member Author

Mark-Simulacrum commented May 27, 2017

@bors r-

This fails on armhf, I think the test just needs to be ignored.

Edit: Specifically, just for myself later:

$ export IMAGE=armhf-gnu
[00:57:20] unexpected errors (from JSON output): [
[00:57:20]     Error {
[00:57:20]         line_num: 11,
[00:57:20]         kind: Some(
[00:57:20]             Error
[00:57:20]         ),
[00:57:20]         msg: "11:1: 13:2: The ABI `\"stdcall\"` is not supported for the current target [E0570]"
[00:57:20]     }
[00:57:20] ]

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 27, 2017
@Mark-Simulacrum
Copy link
Member Author

Ignored the test on arm; r? @eddyb

@eddyb
Copy link
Member

eddyb commented May 27, 2017

@bors r+

@bors
Copy link
Contributor

bors commented May 27, 2017

📌 Commit bf87e17 has been approved by eddyb

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 27, 2017
Allow variadic functions with cdecl calling convention.

Fixes rust-lang#40244.
bors added a commit that referenced this pull request May 27, 2017
Rollup of 10 pull requests

- Successful merges: #42103, #42137, #42162, #42167, #42175, #42207, #42217, #42246, #42249, #42251
- Failed merges:
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 28, 2017
Allow variadic functions with cdecl calling convention.

Fixes rust-lang#40244.
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 28, 2017
Allow variadic functions with cdecl calling convention.

Fixes rust-lang#40244.
@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 28, 2017
bors added a commit that referenced this pull request May 28, 2017
Rollup of 6 pull requests

- Successful merges: #42207, #42217, #42249, #42251, #42260, #42266
- Failed merges:
@bors bors merged commit bf87e17 into rust-lang:master May 28, 2017
@Mark-Simulacrum Mark-Simulacrum deleted the issue-40244 branch June 8, 2019 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants