rustc: Avoid HashStable for DefIndex queries #44584
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
alexcrichton
added
the
S-waiting-on-review
|
This LGTM. |
|
☔ The latest upstream changes (presumably #44678) made this pull request unmergeable. Please resolve the merge conflicts. |
I'm not 100% familiar with this trait and this location, but it looks like there's a default implementation of `DepNodeParams` for anything that implements `HashStable`, but types like `DefId` which have precalculated hashes bypass this default implementation for a speedier one. This commit applies what I believe is the same optimization to `DefIndex`, looking up the local hash for it rather than going through the full `HashStable` rigamarole cc rust-lang#44575
alexcrichton
force-pushed
the
maybe-fix-regression
branch
from
b6127d7
to
fffb99e
Compare
|
Rebased |
|
This landed in #44364 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not 100% familiar with this trait and this location, but it looks like
there's a default implementation of
DepNodeParamsfor anything that implementsHashStable, but types likeDefIdwhich have precalculated hashes bypass thisdefault implementation for a speedier one.
This commit applies what I believe is the same optimization to
DefIndex,looking up the local hash for it rather than going through the full
HashStablerigamarole
cc #44575