Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[beta] ci: Upgrade Android SDK/NDK and refactor to use sdkmanager/avdmanager. #45656

Merged
merged 1 commit into from
Oct 31, 2017
Merged

[beta] ci: Upgrade Android SDK/NDK and refactor to use sdkmanager/avdmanager. #45656

merged 1 commit into from
Oct 31, 2017

Conversation

kennytm
Copy link
Member

@kennytm kennytm commented Oct 31, 2017

This is a backport of #45580

r? @alexcrichton

@kennytm
ci: Upgrade Android SDK/NDK and refactor to use sdkmanager/avdmanager.
baa33ca 
* SDK tools is upgraded to 27.0.0.
   - Refactored to use `sdkmanager`/`avdmanager` instead of the deprecated
     `android` tool.

* The Java version used by Android SDK is downgraded to OpenJDK-8, in order
  to download the SDK through HTTPS.

* NDK is upgrade to r15c.
   - Dropped support for android-9 (2.3 / Gingerbread), the minimal
     supported version is now android-14 (4.0 / Ice Cream Sandwich).
   - Changed the default Android compiler from GCC to clang.
   - For details of change introduced by NDK r15, see
     https://github.com/android-ndk/ndk/wiki/Changelog-r15.
@kennytm kennytm added relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 31, 2017
@rust-highfive
Copy link
Collaborator

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@kennytm kennytm mentioned this pull request Oct 31, 2017
Merged
@alexcrichton
Copy link
Member

@bors: r+ p=1

Higher priority as this is a beta backport

@bors
Copy link
Contributor

bors commented Oct 31, 2017

📌 Commit baa33ca has been approved by alexcrichton

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 31, 2017
@bors
Copy link
Contributor

bors commented Oct 31, 2017

⌛ Testing commit baa33ca with merge e8c426a...

bors added a commit that referenced this pull request Oct 31, 2017
@bors
Auto merge of #45656 - kennytm:sdkmanager-beta, r=alexcrichton
e8c426a 
[beta] ci: Upgrade Android SDK/NDK and refactor to use sdkmanager/avdmanager.

This is a backport of #45580

r? @alexcrichton
@bors
Copy link
Contributor

bors commented Oct 31, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing e8c426a to beta...

@bors bors merged commit baa33ca into rust-lang:beta Oct 31, 2017
@briansmith briansmith mentioned this pull request Jan 22, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kennytm @rust-highfive @alexcrichton @bors