Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not capture stderr in the compiler. Instead just panic silently for fatal errors #47634

Merged
merged 1 commit into from
Jan 26, 2018
Merged

Do not capture stderr in the compiler. Instead just panic silently for fatal errors #47634

merged 1 commit into from
Jan 26, 2018

Conversation

Zoxc
Copy link
Contributor

@Zoxc Zoxc commented Jan 21, 2018

This also has the side-effect of making printing to stderr work in the compiler.

@rust-highfive
Copy link
Collaborator

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@kennytm kennytm added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 21, 2018
@devurandom devurandom mentioned this pull request Jan 21, 2018
Closed
@devurandom
Copy link
Contributor

devurandom commented Jan 21, 2018 •
edited
Loading

This might somewhat fix #43855 and #44244.
#44305 might be somewhat related.

@Zoxc
Copy link
Contributor Author

Zoxc commented Jan 24, 2018

r? @alexcrichton

@alexcrichton
Copy link
Member

@bors: r+

Thanks!

@bors
Copy link
Contributor

bors commented Jan 24, 2018

📌 Commit 124605a has been approved by alexcrichton

@Zoxc
Copy link
Contributor Author

Zoxc commented Jan 26, 2018

@bors r=alexcrichton

@bors
Copy link
Contributor

bors commented Jan 26, 2018

📌 Commit 9a8d6b8 has been approved by alexcrichton

@bors bors merged commit 9a8d6b8 into rust-lang:master Jan 26, 2018
@dtolnay dtolnay mentioned this pull request Jan 27, 2018
Closed
@dtolnay
Copy link
Member

dtolnay commented Jan 27, 2018

Is there a chance that this PR would have changed the error message when a custom derive panics? #47812

@kennytm kennytm mentioned this pull request Feb 10, 2018
Closed
@varkor varkor mentioned this pull request Mar 8, 2018
Closed
@Zoxc Zoxc mentioned this pull request Apr 27, 2018
Merged
@Zoxc Zoxc deleted the no-stderr-sink branch April 27, 2018 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Zoxc @rust-highfive @devurandom @alexcrichton @bors @dtolnay @kennytm @pnkfelix