Error on nested impl Trait and path projections from impl Trait #48084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cramertj
force-pushed
the
impl-trait-errors
branch
from
6c61a5c
to
a7aabd3
Compare
kennytm
added
the
S-waiting-on-review
|
☔ The latest upstream changes (presumably #47843) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
nikomatsakis
requested changes
Feb 13, 2018
| for type_binding in ¶ms.bindings { | ||
| // Type bindings such as `Item=impl Debug` in `Iterator<Item=Debug>` | ||
| // are allowed to contain nested `impl Trait`. | ||
| self.with_impl_trait(None, |this| visit::walk_ty(this, &type_binding.ty)); |
There was a problem hiding this comment.
I think this code would permit this
<dyn Iterator<Item = impl Debug> as Iterator>::Item
which ought not to be allowed
There was a problem hiding this comment.
Oh, probably not, because that is handled by a totally distinct visitor, I see
There was a problem hiding this comment.
Can you add a test for it, anyway?
| struct_span_err!(self.session, t.span, E0666, | ||
| "nested `impl Trait` is not allowed") | ||
| .span_label(outer_impl_trait, "outer `impl Trait`") | ||
| .span_label(t.span, "devilishly nested `impl Trait` here") |
There was a problem hiding this comment.
I don't "devilishly" should be in our error message
There was a problem hiding this comment.
No love for the E0666 easter egg 😢
cramertj
force-pushed
the
impl-trait-errors
branch
from
a7aabd3
to
dbacf0c
Compare
|
Travis is unhappy: https://travis-ci.org/rust-lang/rust/builds/341238329#L1665-L1686 The |
nikomatsakis
approved these changes
Feb 14, 2018
|
r=me once travis is happy |
|
@bors r=nikomatsakis |
|
📌 Commit 9e9c55f has been approved by |
bors
added
S-waiting-on-bors
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 19, 2018
…atsakis Error on nested impl Trait and path projections from impl Trait cc rust-lang#34511 r? @nikomatsakis
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 20, 2018
…atsakis Fixes rust-lang#47311. r? @nrc
bors
added a commit
that referenced
this pull request
Feb 20, 2018
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 24, 2018
…atsakis Error on nested impl Trait and path projections from impl Trait cc rust-lang#34511 r? @nikomatsakis
bors
added a commit
that referenced
this pull request
Feb 24, 2018
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 24, 2018
…atsakis Error on nested impl Trait and path projections from impl Trait cc rust-lang#34511 r? @nikomatsakis
bors
added a commit
that referenced
this pull request
Feb 24, 2018
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #34511
r? @nikomatsakis