Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert #48105 ("Implement excluding a build-step via --exclude") #48242

Closed
wants to merge 1 commit into from
Closed

Revert #48105 ("Implement excluding a build-step via --exclude") #48242

wants to merge 1 commit into from

Conversation

kennytm
Copy link
Member

@kennytm kennytm commented Feb 15, 2018

This PR reverts #48105, since we found that the PR causes some tests not being run. In particular, the entire "toolstate" job has been skipped.

r? @Mark-Simulacrum

@kennytm
Revert "Auto merge of rust-lang#48105 - Mark-Simulacrum:exclude-paths…
8c2ca6c 
…, r=alexcrichton"

This reverts commit c83fa5d, reversing
changes made to 90759be.
@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 15, 2018
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 15, 2018
@Mark-Simulacrum
Copy link
Member

@bors p=50 r+

@bors
Copy link
Contributor

bors commented Feb 15, 2018

📌 Commit 8c2ca6c has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 15, 2018
@bors
Copy link
Contributor

bors commented Feb 15, 2018

⌛ Testing commit 8c2ca6c with merge 9119daa96db70348033ac6d3b204aa9345c1598a...

@bors
Copy link
Contributor

bors commented Feb 15, 2018

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 15, 2018
@Mark-Simulacrum
Copy link
Member

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 16, 2018
@Mark-Simulacrum
Copy link
Member

Actually, I'm fairly certain that I've come up with a patch that fixes the behavior... so closing.

@pnkfelix pnkfelix mentioned this pull request Feb 16, 2018
Closed
@pnkfelix pnkfelix reopened this Feb 16, 2018
@pnkfelix
Copy link
Member

I think we should land this revert unless @Mark-Simulacrum 's patch (which was not linked and thus I do not know if there's even a PR for it) is also going to fix #48268

@pnkfelix
Copy link
Member

Ah I assume that @Mark-Simulacrum 's patch is at PR #48252

@pnkfelix pnkfelix closed this Feb 16, 2018
@kennytm kennytm deleted the revert-48105 branch February 17, 2018 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kennytm @Mark-Simulacrum @bors @pnkfelix @rust-highfive