Removed ascii_ctype

[hellow554]

This is stable since rust 1.24.0 and is no longer behind a feature gate

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[mattico]

Reference: #39658 (comment)

Functions were initially implemented on AsciiExt, then moved to inherent impls on u8 and char, then stabilized.

It's probably time to remove the old AsciiExt methods (here), but that doesn't have to happen in this PR.

[hellow554]

Didn't see that issue. I will adresse the other tasks as well (I hope), give me one day :)

[hellow554]

@mattico I may need your help here.

error[E0407]: method `is_ascii_control` is not a member of trait `AsciiExt`
   --> libstd/ascii.rs:209:9
    |
209 |         fn is_ascii_control(&self) -> bool { self.is_ascii_control() }
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not a member of trait `AsciiExt`
...
218 |     delegating_ascii_ctype_methods!();
    |     ---------------------------------- in this macro invocation

Do I want to remove the macro at all? I'm not quiet sure.

error[E0407]: method `is_ascii_hexdigit` is not a member of trait `AsciiExt`
   --> libstd/ascii.rs:261:5
    |
261 | /     fn is_ascii_hexdigit(&self) -> bool {
262 | |         self.iter().all(|b| b.is_ascii_hexdigit())
263 | |     }
    | |_____^ not a member of trait `AsciiExt`

Same here. I'm not sure, why this fails. Am I missing something?

[shepmaster]

Ping from triage, @aturon !

[mattico]

I think all you have to do is remove the delegating_ascii_ctype_methods!() macro.

[hellow554]

I'm sorry, but I cannot get this working. I'm not very sure what to do and which macro does what, because I'm not that deep into the codebase. I just tried to get rid of the feature flag in the doctests :)
A PR based on #39658 (comment) would be nice to see

[LukasKalbertodt]

@hellow554 Sorry for replying so late, I didn't see this thread.

I wrote this macro to avoid boilerplate code and you should be able to remove it. I could offer some help/mentoring with the PR, if you want @hellow554? I'm by no means experienced in the compiler source, but I could help in this case, I think.