Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport LLVM fixes for a JumpThreading / assume intrinsic bug #48583

Merged
merged 2 commits into from
Mar 3, 2018
Merged

Backport LLVM fixes for a JumpThreading / assume intrinsic bug #48583

merged 2 commits into from
Mar 3, 2018

Conversation

dotdash
Copy link
Contributor

@dotdash dotdash commented Feb 27, 2018

This fixes the original cause of #48116 and restores the assume intrinsic that was removed as a workaround.

r? @alexcrichton

@alexcrichton
Copy link
Member

@bors: r+

Thanks so much for the continued investigation here @dotdash!

@bors
Copy link
Contributor

bors commented Feb 27, 2018

📌 Commit f05d967 has been approved by alexcrichton

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 27, 2018
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Feb 28, 2018

📌 Commit 93cfb2a has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Feb 28, 2018

🌲 The tree is currently closed for pull requests below priority 200, this pull request will be tested once the tree is reopened

@alexcrichton alexcrichton mentioned this pull request Feb 28, 2018
Closed
@Manishearth
Copy link
Member

@bors p=2

prioritizing risky-to-rollup PRs so they get tested first

@bors
Copy link
Contributor

bors commented Mar 2, 2018

⌛ Testing commit 93cfb2a with merge 6bf7d58...

bors added a commit that referenced this pull request Mar 2, 2018
@bors
Auto merge of #48583 - dotdash:jt_assume, r=alexcrichton
6bf7d58 
Backport LLVM fixes for a JumpThreading / assume intrinsic bug

This fixes the original cause of #48116 and restores the assume intrinsic that was removed as a workaround.

r? @alexcrichton
@bors
Copy link
Contributor

bors commented Mar 2, 2018

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 2, 2018
@kennytm
Copy link
Member

kennytm commented Mar 2, 2018

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 2, 2018
@bors
Copy link
Contributor

bors commented Mar 3, 2018

⌛ Testing commit 93cfb2a with merge 3b8bd53...

bors added a commit that referenced this pull request Mar 3, 2018
@bors
Auto merge of #48583 - dotdash:jt_assume, r=alexcrichton
3b8bd53 
Backport LLVM fixes for a JumpThreading / assume intrinsic bug

This fixes the original cause of #48116 and restores the assume intrinsic that was removed as a workaround.

r? @alexcrichton
@bors
Copy link
Contributor

bors commented Mar 3, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 3b8bd53 to master...

@bors bors merged commit 93cfb2a into rust-lang:master Mar 3, 2018
@dotdash dotdash deleted the jt_assume branch January 20, 2020 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcrichton alexcrichton Awaiting requested review from alexcrichton

Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dotdash @alexcrichton @bors @Manishearth @kennytm