Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize underscore lifetimes #49458

Merged
merged 1 commit into from
Mar 29, 2018
Merged

Stabilize underscore lifetimes #49458

merged 1 commit into from
Mar 29, 2018

Conversation

cramertj
Copy link
Member

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 28, 2018
@bors
Copy link
Contributor

bors commented Mar 28, 2018

☔ The latest upstream changes (presumably #49394) made this pull request unmergeable. Please resolve the merge conflicts.

@cramertj cramertj force-pushed the stable-underscore-lt branch 5 times, most recently from 40ac247 to c3f0228 Compare March 28, 2018 22:27
@cramertj
Copy link
Member Author

@bors r=nikomatsakis p=100

b.c. he said so

@bors
Copy link
Contributor

bors commented Mar 28, 2018

📌 Commit e6e6bd2 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 28, 2018
@bors
Copy link
Contributor

bors commented Mar 29, 2018

⌛ Testing commit e6e6bd2 with merge 1e652bd...

bors added a commit that referenced this pull request Mar 29, 2018
@bors
Auto merge of #49458 - cramertj:stable-underscore-lt, r=nikomatsakis
1e652bd 
Stabilize underscore lifetimes

r? @nikomatsakis
@bors
Copy link
Contributor

bors commented Mar 29, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing 1e652bd to master...

@bors bors merged commit e6e6bd2 into rust-lang:master Mar 29, 2018
@cramertj cramertj deleted the stable-underscore-lt branch March 30, 2018 11:23
@kennytm kennytm added the relnotes Marks issues that should be documented in the release notes of the next release. label Apr 4, 2018
@kennytm kennytm mentioned this pull request Apr 4, 2018
Merged
@steveklabnik steveklabnik mentioned this pull request Apr 4, 2018
Closed
@alercah
Copy link
Contributor

alercah commented May 11, 2018 •
edited
Loading

For anyone coming from the release notes, you can read the RFC of which this feature forms a part.

@kngwyu kngwyu mentioned this pull request Apr 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cramertj @bors @alercah @kennytm @nikomatsakis @rust-highfive