Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct a few stability attributes #49673

Merged
merged 1 commit into from
Apr 9, 2018
Merged

Correct a few stability attributes #49673

merged 1 commit into from
Apr 9, 2018

Conversation

ollie27
Copy link
Member

@ollie27 ollie27 commented Apr 5, 2018

This could be backported to beta like #49612

@est31
Copy link
Member

est31 commented Apr 5, 2018

the never type was stabilized in 1.26.0 by #47630 and it should be shown as such in the docs

it miiight be that it will get unstabilized. better not change docs for now until this is resolved.

Edit: see #49593

@pietroalbini pietroalbini added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 5, 2018
@ollie27
Copy link
Member Author

ollie27 commented Apr 5, 2018

I've removed the never type change.

@shepmaster
Copy link
Member

r? @sfackler

@rust-highfive rust-highfive assigned sfackler and unassigned shepmaster Apr 8, 2018
@sfackler
Copy link
Member

sfackler commented Apr 9, 2018

@bors r+

@bors
Copy link
Contributor

bors commented Apr 9, 2018

📌 Commit 521e41e has been approved by sfackler

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 9, 2018
@bors
Copy link
Contributor

bors commented Apr 9, 2018

⌛ Testing commit 521e41e with merge 8ae79ef...

bors added a commit that referenced this pull request Apr 9, 2018
Correct a few stability attributes

* `const_indexing` language feature was stabilized in 1.26.0 by #46882
* `Display` impls for `PanicInfo` and `Location` were stabilized in 1.26.0 by #47687
* `TrustedLen` is still unstable so its impls should be as well even though `RangeInclusive` was stabilized by #47813
* `!Send` and `!Sync` for `Args` and `ArgsOs` were stabilized in 1.26.0 by #48005
* `EscapeDefault` has been stable since 1.0.0 so should continue to show that even though it was moved to core in #48735

This could be backported to beta like #49612
@bors
Copy link
Contributor

bors commented Apr 9, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: sfackler
Pushing 8ae79ef to master...

@bors bors merged commit 521e41e into rust-lang:master Apr 9, 2018
@ollie27 ollie27 deleted the stab branch April 9, 2018 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants