Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rustfmt and rls #50236

Merged
merged 2 commits into from
Apr 26, 2018
Merged

Update rustfmt and rls #50236

merged 2 commits into from
Apr 26, 2018

Conversation

nrc
Copy link
Member

@nrc nrc commented Apr 25, 2018

@rust-highfive
Copy link
Collaborator

warning Warning warning

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 25, 2018
@alexcrichton
Copy link
Member

@bors: r+ p=1

@bors
Copy link
Contributor

bors commented Apr 25, 2018

📌 Commit 127f9a6 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 25, 2018
@bors
Copy link
Contributor

bors commented Apr 26, 2018

⌛ Testing commit 127f9a6 with merge d5d4f231c0617fb87903c842992873c4a00cb7b0...

@bors
Copy link
Contributor

bors commented Apr 26, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 26, 2018
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-distcheck of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
[00:02:45]  Downloading rustc-serialize v0.3.24
[00:02:46]  Downloading idna v0.1.4
[00:02:46]  Downloading either v1.5.0
[00:02:46]  Downloading rls-vfs v0.4.5
[00:02:46]  Downloading skeptic v0.13.2
[00:02:46]  Downloading open v1.2.1
[00:02:47]  Downloading diff v0.1.11
[00:02:47]  Downloading rls-rustc v0.2.2
[00:02:47]  Downloading walkdir v1.0.7
---
[00:16:17] * wrapping_int_impl                lib      unstable     None    
[00:16:17] * wrapping_iter_arith              lib      stable       1.14.0  
[00:16:17] * wrapping_neg                     lib      stable       1.10.0  
[00:16:17] * wrapping_ref                     lib      stable       1.14.0  
[00:16:18] invalid license MPL-2.0 in /checkout/obj/build/tmp/distcheck/src/vendor/colored/Cargo.toml
[00:16:18] some tidy checks failed
[00:16:18] 
[00:16:18] 
[00:16:18] command did not execute successfully: "/checkout/obj/build/tmp/distcheck/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/obj/build/tmp/distcheck/src" "/checkout/obj/build/tmp/distcheck/build/x86_64-unknown-linux-gnu/stage0/bin/cargo"
[00:16:18] 
[00:16:18] 
[00:16:18] failed to run: /checkout/obj/build/tmp/distcheck/build/bootstrap/debug/bootstrap test
[00:16:18] Build completed unsuccessfully in 0:03:07
[00:16:18] Build completed unsuccessfully in 0:03:07
[00:16:18] make: *** [check] Error 1
[00:16:18] Makefile:58: recipe for target 'check' failed
[00:16:18] 
[00:16:18] 
[00:16:18] command did not execute successfully: "make" "check"
[00:16:18] 
[00:16:18] 
[00:16:18] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test distcheck
[00:16:18] Build completed unsuccessfully in 0:13:08

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

1 similar comment
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-distcheck of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
[00:02:45]  Downloading rustc-serialize v0.3.24
[00:02:46]  Downloading idna v0.1.4
[00:02:46]  Downloading either v1.5.0
[00:02:46]  Downloading rls-vfs v0.4.5
[00:02:46]  Downloading skeptic v0.13.2
[00:02:46]  Downloading open v1.2.1
[00:02:47]  Downloading diff v0.1.11
[00:02:47]  Downloading rls-rustc v0.2.2
[00:02:47]  Downloading walkdir v1.0.7
---
[00:16:17] * wrapping_int_impl                lib      unstable     None    
[00:16:17] * wrapping_iter_arith              lib      stable       1.14.0  
[00:16:17] * wrapping_neg                     lib      stable       1.10.0  
[00:16:17] * wrapping_ref                     lib      stable       1.14.0  
[00:16:18] invalid license MPL-2.0 in /checkout/obj/build/tmp/distcheck/src/vendor/colored/Cargo.toml
[00:16:18] some tidy checks failed
[00:16:18] 
[00:16:18] 
[00:16:18] command did not execute successfully: "/checkout/obj/build/tmp/distcheck/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/obj/build/tmp/distcheck/src" "/checkout/obj/build/tmp/distcheck/build/x86_64-unknown-linux-gnu/stage0/bin/cargo"
[00:16:18] 
[00:16:18] 
[00:16:18] failed to run: /checkout/obj/build/tmp/distcheck/build/bootstrap/debug/bootstrap test
[00:16:18] Build completed unsuccessfully in 0:03:07
[00:16:18] Build completed unsuccessfully in 0:03:07
[00:16:18] make: *** [check] Error 1
[00:16:18] Makefile:58: recipe for target 'check' failed
[00:16:18] 
[00:16:18] 
[00:16:18] command did not execute successfully: "make" "check"
[00:16:18] 
[00:16:18] 
[00:16:18] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test distcheck
[00:16:18] Build completed unsuccessfully in 0:13:08

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@nrc
Copy link
Member Author

nrc commented Apr 26, 2018

r? @alexcrichton for the second commit which adds a license check exception

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Apr 26, 2018

📌 Commit 612830d has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 26, 2018
@bors
Copy link
Contributor

bors commented Apr 26, 2018

⌛ Testing commit 612830d with merge c187787...

bors added a commit that referenced this pull request Apr 26, 2018
@bors
Auto merge of #50236 - nrc:update, r=alexcrichton
c187787 
Update rustfmt and rls

r? @alexcrichton
@bors
Copy link
Contributor

bors commented Apr 26, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing c187787 to master...

@bors bors merged commit 612830d into rust-lang:master Apr 26, 2018
@kennytm-githubbot
Copy link

📣 Toolstate changed by #50236!

Tested on commit c187787.
Direct link to PR: #50236

🎉 rls on windows: build-fail → test-pass.
🎉 rls on linux: build-fail → test-pass.
💔 rustfmt on windows: test-pass → test-fail (cc @nrc).
💔 rustfmt on linux: test-pass → test-fail (cc @nrc).

kennytm-githubbot added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Apr 26, 2018
@kennytm-githubbot
📣 Toolstate changed by rust-lang/rust#50236!
19d10e0 
Tested on commit rust-lang/rust@c187787.
Direct link to PR: <rust-lang/rust#50236>

🎉 rls on windows: build-fail → test-pass.
🎉 rls on linux: build-fail → test-pass.
💔 rustfmt on windows: test-pass → test-fail (cc @nrc).
💔 rustfmt on linux: test-pass → test-fail (cc @nrc).
This was referenced Apr 26, 2018
Closed
Closed
@nrc
Copy link
Member Author

nrc commented Apr 26, 2018

@kennytm can I get the logs for the rustfmt test failure at all? I can't reproduce the failure locally on Linux (./x.py test src/tools/rustfmt passes)

@kennytm
Copy link
Member

kennytm commented Apr 26, 2018

@nrc The raw log is in https://api.travis-ci.org/v3/job/371374420/log.txt, the test failures are:

[01:37:28] failures:
[01:37:28] 
[01:37:28] ---- test::verify_check_works stdout ----
[01:37:28] 	thread 'test::verify_check_works' panicked at 'No such file or directory (os error 2)', /cargo/registry/src/github.mirror.nvdadr.com-1ecc6299db9ec823/assert_cli-0.5.4/src/assert.rs:368:13
[01:37:28] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[01:37:28] 
[01:37:28] ---- test::verify_diff_works stdout ----
[01:37:28] 	thread 'test::verify_diff_works' panicked at 'No such file or directory (os error 2)', /cargo/registry/src/github.mirror.nvdadr.com-1ecc6299db9ec823/assert_cli-0.5.4/src/assert.rs:368:13
[01:37:28] 
[01:37:28] 
[01:37:28] failures:
[01:37:28]     test::verify_check_works
[01:37:28]     test::verify_diff_works
[01:37:28] 
[01:37:28] test result: FAILED. 56 passed; 2 failed; 0 ignored; 0 measured; 0 filtered out

@nrc
Copy link
Member Author

nrc commented Apr 26, 2018

Thanks @kennytm !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nrc @rust-highfive @alexcrichton @bors @kennytm-githubbot @kennytm