Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilise raw_identifiers feature #53236

Merged
merged 1 commit into from
Aug 21, 2018
Merged

Stabilise raw_identifiers feature #53236

merged 1 commit into from
Aug 21, 2018

Conversation

alexreg
Copy link
Contributor

@alexreg alexreg commented Aug 9, 2018 •
edited
Loading

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 9, 2018
@cramertj
Copy link
Member

cramertj commented Aug 9, 2018

Before merging this we need docs PRs against the reference, the book, and Rust by Example.

@rust-highfive

This comment has been minimized.

Sign in to view
@alexreg
Copy link
Contributor Author

alexreg commented Aug 9, 2018

@cramertj Was planning on doing ones for the Reference and Rust By Example, but how do you think it would fit in the Book?

@Havvy
Copy link
Contributor

Havvy commented Aug 9, 2018

The current rules state that you just need to open issues, not full fledged PRs. Though of course, we prefer PRs over issues. But if you're not sure what to write in a PR, file an issue.

@alexreg alexreg changed the title Stabilise raw_identifiers feature. Stabilise raw_identifiers feature Aug 9, 2018
@alexreg
Copy link
Contributor Author

alexreg commented Aug 9, 2018

@Havvy Okay. I'll open a PR with what I think is most sane, and we can go from there, if people aren't happy with it...

@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@alexreg
Copy link
Contributor Author

alexreg commented Aug 10, 2018

Okay, I think we're good to go now, at least as far as this PR itself is concerned. :-)

@kennytm kennytm added relnotes Marks issues that should be documented in the release notes of the next release. T-lang Relevant to the language team, which will review and decide on the PR/issue. labels Aug 10, 2018
@cramertj
Copy link
Member

@bors r+

Assuming @alexreg will also open an issue against the book :)

@bors
Copy link
Contributor

bors commented Aug 10, 2018

📌 Commit 176f8c2 has been approved by cramertj

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 10, 2018
@alexreg
Copy link
Contributor Author

alexreg commented Aug 10, 2018

@cramertj I already opened a PR against the book. From the Forge guide, I thought that was enough... what should the issue be about?

@kennytm kennytm mentioned this pull request Aug 10, 2018
Closed
@cramertj
Copy link
Member

@alexreg Oh, I see it linked at the top now. Thanks! I just missed it before.

kennytm added a commit to kennytm/rust that referenced this pull request Aug 13, 2018
@kennytm
Rollup merge of rust-lang#53236 - alexreg:stabilise-raw-idents, r=cra…
5931aa7 
…mertj

Stabilise raw_identifiers feature

* [Reference PR](rust-lang/reference#395)
* [Book PR](rust-lang/book#1480)
* [Rust by Example PR](rust-lang/rust-by-example#1095)

Closes rust-lang#48589.

r? @cramertj
CC @cuviper @Centril
@kennytm kennytm mentioned this pull request Aug 13, 2018
Closed
@kennytm kennytm mentioned this pull request Aug 14, 2018
Merged
@kennytm
Copy link
Member

kennytm commented Aug 15, 2018

@bors r-

Merge conflicts in the UI tests.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 15, 2018
@alexreg
Copy link
Contributor Author

alexreg commented Aug 15, 2018

@kennytm Done!

@kennytm
Copy link
Member

kennytm commented Aug 15, 2018

@alexreg you forgot to delete this file: https://github.com/rust-lang/rust/blob/a31c363881066e26b6eef43be3eee26073740795/src/test/ui/feature-gates/feature-gate-raw-identifiers.rs

@alexreg
Copy link
Contributor Author

alexreg commented Aug 15, 2018

Ah, rubbish... done now. :-P

@frewsxcv frewsxcv added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 17, 2018
@kennytm
Copy link
Member

kennytm commented Aug 21, 2018

@bors r=cramertj p=1

@bors
Copy link
Contributor

bors commented Aug 21, 2018

📌 Commit e221fcc has been approved by cramertj

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 21, 2018
@bors
Copy link
Contributor

bors commented Aug 21, 2018

⌛ Testing commit e221fcc with merge a9d4967...

bors added a commit that referenced this pull request Aug 21, 2018
@bors
Auto merge of #53236 - alexreg:stabilise-raw-idents, r=cramertj
a9d4967 
Stabilise raw_identifiers feature

* [Reference PR](rust-lang/reference#395)
* [Book PR](rust-lang/book#1480)
* [Rust by Example PR](rust-lang/rust-by-example#1095)

Closes #48589.

r? @cramertj
CC @cuviper @Centril
@bors
Copy link
Contributor

bors commented Aug 21, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: cramertj
Pushing a9d4967 to master...

@bors bors merged commit e221fcc into rust-lang:master Aug 21, 2018
@bors bors mentioned this pull request Aug 21, 2018
Merged
@haraldh haraldh mentioned this pull request Oct 26, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cramertj cramertj

Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-lang Relevant to the language team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@alexreg @cramertj @rust-highfive @Havvy @bors @kennytm @frewsxcv