Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable fatal warnings for the wasm32 linker #54258

Merged
merged 1 commit into from
Sep 21, 2018
Merged

Enable fatal warnings for the wasm32 linker #54258

merged 1 commit into from
Sep 21, 2018

Conversation

alexcrichton
Copy link
Member

Historically LLD has emitted warnings for various reasons but all the bugs have
since been fixed (yay!) and by enabling fatal warnings we should be able to head
off bugs like #53390 sooner.

@alexcrichton
Enable fatal warnings for the wasm32 linker
4265256 
Historically LLD has emitted warnings for various reasons but all the bugs have
since been fixed (yay!) and by enabling fatal warnings we should be able to head
off bugs like rust-lang#53390 sooner.
@rust-highfive
Copy link
Collaborator

r? @matthewjasper

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 15, 2018
@matthewjasper
Copy link
Contributor

r? @eddyb

@rust-highfive rust-highfive assigned eddyb and unassigned matthewjasper Sep 15, 2018
@eddyb
Copy link
Member

eddyb commented Sep 15, 2018

@bors r+

@bors
Copy link
Contributor

bors commented Sep 15, 2018

📌 Commit 4265256 has been approved by eddyb

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 15, 2018
@bors
Copy link
Contributor

bors commented Sep 17, 2018

⌛ Testing commit 4265256 with merge 5f9b85bcdfb27b4ae4dc04c930328075a8e5c6d2...

@bors
Copy link
Contributor

bors commented Sep 17, 2018

💔 Test failed - status-travis

@rust-highfive
Copy link
Collaborator

The job dist-mips64-linux of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
travis_time:end:1f63325c:start=1537166038005917058,finish=1537166038009411423,duration=3494365
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:07e8d238
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:18210700
travis_time:start:18210700
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:0b2f9eb4
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 17, 2018
@alexcrichton
Copy link
Member Author

@bors: retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 17, 2018
@bors
Copy link
Contributor

bors commented Sep 17, 2018

⌛ Testing commit 4265256 with merge 9d9939d5a604a229e2f6eb042d02ffbf4bc97f12...

@bors
Copy link
Contributor

bors commented Sep 17, 2018

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 17, 2018
@alexcrichton
Copy link
Member Author

@bors: retry

Looks like a travis issue?

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 17, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Sep 20, 2018
@kennytm
Rollup merge of rust-lang#54258 - alexcrichton:lld-fatal-warnings, r=…
13cea8e 
…eddyb

Enable fatal warnings for the wasm32 linker

Historically LLD has emitted warnings for various reasons but all the bugs have
since been fixed (yay!) and by enabling fatal warnings we should be able to head
off bugs like rust-lang#53390 sooner.
@kennytm kennytm mentioned this pull request Sep 20, 2018
Merged
bors added a commit that referenced this pull request Sep 20, 2018
@bors
Auto merge of #54389 - kennytm:rollup, r=kennytm
2fa1390 
Rollup of 15 pull requests

Successful merges:

 - #52813 (Duration div mul extras)
 - #53470 (Warn about metadata loader errors)
 - #54233 (Remove LLVM 3.9 workaround.)
 - #54257 (Switch wasm math symbols to their original names)
 - #54258 (Enable fatal warnings for the wasm32 linker)
 - #54266 (Update LLVM to fix "bool" arguments on PPC32)
 - #54290 (Switch linker for aarch64-pc-windows-msvc from LLD to MSVC)
 - #54292 (Suggest array indexing when tuple indexing on an array)
 - #54295 (A few cleanups and minor improvements to rustc/traits)
 - #54298 (miri: correctly compute expected alignment for field)
 - #54333 (Update The Book to latest)
 - #54337 (Remove unneeded clone() from tests in librustdoc)
 - #54346 (rustc: future-proof error reporting for polymorphic constants in types.)
 - #54362 (Pass --batch to gdb)
 - #54367 (Add regression test for thread local static mut borrows)
@bors bors merged commit 4265256 into rust-lang:master Sep 21, 2018
@alexcrichton alexcrichton deleted the lld-fatal-warnings branch October 8, 2018 19:59
@jrandall jrandall mentioned this pull request Jun 14, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eddyb eddyb

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexcrichton @rust-highfive @matthewjasper @eddyb @bors