Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize self_struct_ctor feature. #56365

Merged
merged 5 commits into from
Nov 30, 2018

Conversation

alexreg
Copy link
Contributor

@alexreg alexreg commented Nov 30, 2018

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 30, 2018
@alexreg alexreg force-pushed the stabilise-self_struct_ctor branch 2 times, most recently from c10ed56 to 3f28e7e Compare November 30, 2018 03:20
Copy link
Contributor

@Centril Centril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; thanks!

@Centril
Copy link
Contributor

Centril commented Nov 30, 2018

@bors r+

@bors
Copy link
Contributor

bors commented Nov 30, 2018

📌 Commit 3f28e7e9560325d4e83ad6211cf0852124bbaf5f has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 30, 2018
@rust-highfive

This comment has been minimized.

@Centril
Copy link
Contributor

Centril commented Nov 30, 2018

Let's try again;
@bors r+

@bors
Copy link
Contributor

bors commented Nov 30, 2018

📌 Commit 31db25db3fd4b43306e42f52d8edac22658be238 has been approved by Centril

@rust-highfive

This comment has been minimized.

@Centril Centril added the relnotes Marks issues that should be documented in the release notes of the next release. label Nov 30, 2018
Copy link
Contributor

@Centril Centril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; but let's wait on tests to pass first to be sure. :)

@rust-highfive

This comment has been minimized.

@Centril
Copy link
Contributor

Centril commented Nov 30, 2018

@bors r+

@bors
Copy link
Contributor

bors commented Nov 30, 2018

📌 Commit 24717fd has been approved by Centril

kennytm added a commit to kennytm/rust that referenced this pull request Nov 30, 2018
… r=Centril

Stabilize self_struct_ctor feature.

[**Tracking Issue**](rust-lang#51994)
bors added a commit that referenced this pull request Nov 30, 2018
Rollup of 19 pull requests

Successful merges:

 - #55011 (Add libstd Cargo feature "panic_immediate_abort")
 - #55821 (Use sort_by_cached_key when the key function is not trivial/free)
 - #56014 (add test for issue #21335)
 - #56131 (Assorted tweaks)
 - #56214 (Implement chalk unification routines)
 - #56216 (Add TryFrom<&[T]> for [T; $N] where T: Copy)
 - #56268 (Reuse the `P` in `InvocationCollector::fold_{,opt_}expr`.)
 - #56324 (Use raw_entry for more efficient interning)
 - #56336 (Clean up and streamline the pretty-printer)
 - #56337 (Fix const_fn ICE with non-const function pointer)
 - #56339 (Remove not used option)
 - #56341 (Rename conversion util; remove duplicate util in librustc_codegen_llvm.)
 - #56349 (rustc 1.30.0's linker flavor inference is a non-backwards compat change to -Clinker)
 - #56355 (Add inline attributes and add unit to CommonTypes)
 - #56360 (Optimize local linkchecker program)
 - #56364 (Fix panic with outlives in existential type)
 - #56365 (Stabilize self_struct_ctor feature.)
 - #56367 (Moved some feature gate tests to correct location)
 - #56373 (Update books)
@bors bors merged commit 24717fd into rust-lang:master Nov 30, 2018
@Centril Centril added this to the 1.32 milestone Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants