Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in from_key_hashed_nocheck #56561

Merged
merged 1 commit into from
Dec 7, 2018
Merged

Fix bug in from_key_hashed_nocheck #56561

merged 1 commit into from
Dec 7, 2018

Conversation

Zoxc
Copy link
Contributor

@Zoxc Zoxc commented Dec 6, 2018

No description provided.

@rust-highfive
Copy link
Collaborator

r? @Kimundi

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 6, 2018
@Zoxc
Copy link
Contributor Author

Zoxc commented Dec 6, 2018

r? @gankro

@rust-highfive rust-highfive assigned Gankra and unassigned Kimundi Dec 6, 2018
@Gankra
Copy link
Contributor

Gankra commented Dec 6, 2018

@bors r+

@bors
Copy link
Contributor

bors commented Dec 6, 2018

@gankro: 🔑 Insufficient privileges: Not in reviewers

@varkor
Copy link
Member

varkor commented Dec 6, 2018

@bors r=Gankro

@bors
Copy link
Contributor

bors commented Dec 6, 2018

📌 Commit 7df4b81 has been approved by Gankro

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 6, 2018
@kennytm
Copy link
Member

kennytm commented Dec 6, 2018

@bors rollup

@Gankra
Copy link
Contributor

Gankra commented Dec 7, 2018

I would rather land this high priority, since it's a memory safety bug.

kennytm added a commit to kennytm/rust that referenced this pull request Dec 7, 2018
@kennytm
Rollup merge of rust-lang#56561 - Zoxc:too-raw, r=Gankro
06f3b57 
Fix bug in from_key_hashed_nocheck
@kennytm kennytm mentioned this pull request Dec 7, 2018
Merged
bors added a commit that referenced this pull request Dec 7, 2018
@bors
Auto merge of #56581 - kennytm:rollup, r=kennytm
fc84f5f 
Rollup of 7 pull requests

Successful merges:

 - #56000 (Add Armv8-M Mainline targets)
 - #56250 (Introduce ptr::hash for references)
 - #56434 (Improve query cycle errors for parallel queries)
 - #56516 (Replace usages of `..i + 1` ranges with `..=i`.)
 - #56555 (Send textual profile data to stderr, not stdout)
 - #56561 (Fix bug in from_key_hashed_nocheck)
 - #56574 (Fix a stutter in the docs for slice::exact_chunks)

Failed merges:

r? @ghost
@bors bors merged commit 7df4b81 into rust-lang:master Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Gankra Gankra

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Zoxc @rust-highfive @Gankra @bors @varkor @kennytm @Kimundi