Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2018 edition - confusing error message when declaring unnamed parameters #56584

Merged
merged 2 commits into from
Dec 15, 2018
Merged

2018 edition - confusing error message when declaring unnamed parameters #56584

merged 2 commits into from
Dec 15, 2018

Conversation

davidtwco
Copy link
Member

Fixes #53990.

This PR adds a note providing context for the change to argument
names being required in the 2018 edition for trait methods and a
suggestion for the fix.

@rust-highfive
Copy link
Collaborator

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 7, 2018
@Nemo157

This comment has been minimized.

Sign in to view
@eddyb
Copy link
Member

eddyb commented Dec 7, 2018

r? @nikomatsakis

@rust-highfive rust-highfive assigned nikomatsakis and unassigned eddyb Dec 7, 2018
@davidtwco
Add context for RFC 1685 change in 2018 edition.
e4dc15a 
This commit adds a note providing context for the change to argument
names being required in the 2018 edition for trait methods.
@davidtwco
Add suggestion for underscore binding fix.
7fcf31b 
This commit emits a suggestion for adding an underscore binding to
arguments in trait methods that previously did not have a argument name
specified.
@davidtwco
Copy link
Member Author

It seems like the compatibility warning and the hard error could use the same/similar error messages (playground)

Ah, good point @Nemo157. I've updated the messages.

@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Dec 11, 2018

📌 Commit 7fcf31b has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 11, 2018
@bors
Copy link
Contributor

bors commented Dec 11, 2018

⌛ Testing commit 7fcf31b with merge e8c8d274b0b611a5d4711af6095d477729436e30...

@bors
Copy link
Contributor

bors commented Dec 11, 2018

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 11, 2018
@rust-highfive
Copy link
Collaborator

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
Checking out files: 100% (17616/17616), done.
travis_time:end:08c8ad60:start=1544571738042518000,finish=1544571750320195000,duration=12277677000
$ cd rust-lang/rust
$ git checkout -qf e8c8d274b0b611a5d4711af6095d477729436e30
fatal: reference is not a tree: e8c8d274b0b611a5d4711af6095d477729436e30
The command "git checkout -qf e8c8d274b0b611a5d4711af6095d477729436e30" failed and exited with 128 during .
Your build has been stopped.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@alexcrichton
Copy link
Member

@bors: retry

  • CI automation hiccup

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 11, 2018
@bors
Copy link
Contributor

bors commented Dec 15, 2018

⌛ Testing commit 7fcf31b with merge 747a5e5...

bors added a commit that referenced this pull request Dec 15, 2018
@bors
Auto merge of #56584 - davidtwco:issue-53990, r=nikomatsakis
747a5e5 
2018 edition - confusing error message when declaring unnamed parameters

Fixes #53990.

This PR adds a note providing context for the change to argument
names being required in the 2018 edition for trait methods and a
suggestion for the fix.
@bors
Copy link
Contributor

bors commented Dec 15, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing 747a5e5 to master...

@bors bors merged commit 7fcf31b into rust-lang:master Dec 15, 2018
@davidtwco davidtwco deleted the issue-53990 branch December 15, 2018 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikomatsakis nikomatsakis nikomatsakis approved these changes

Assignees

@nikomatsakis nikomatsakis

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2018 edition - confusing error message when declaring unnamed parameters
7 participants
@davidtwco @rust-highfive @Nemo157 @eddyb @nikomatsakis @bors @alexcrichton