Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 32 pull requests #56775

Closed
wants to merge 76 commits into from
Closed

Rollup of 32 pull requests #56775

wants to merge 76 commits into from

Commits on Nov 28, 2018

  1. Remove not used mod

    `mir_stats` mod has not been used since c1ff104.
    yui-knk committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    934e4d3 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2018

  1. Configuration menu
    Copy the full SHA
    eaeebb5 View commit details
    Browse the repository at this point in the history
  2. Fix line length

    JohnGinger committed Dec 2, 2018
    Configuration menu
    Copy the full SHA
    54026c1 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2018

  1. Fix stderr files

    JohnGinger committed Dec 3, 2018
    Configuration menu
    Copy the full SHA
    4cf5702 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    70536d4 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2018

  1. Configuration menu
    Copy the full SHA
    c0e3f4b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    86822eb View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2018

  1. rustdoc: Fix local reexports of proc macros

    Filter out `ProcMacroStub`s to avoid an ICE during cleaning.
    
    Also add proc macros to `cache().paths` so it can generate links.
    ollie27 committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    0bb075f View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2018

  1. Configuration menu
    Copy the full SHA
    aa04285 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    85b50d0 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2018

  1. Document time of back operations of a Linked List

    Popping and pushing from the end of a linked list is constant time. This
    documentation is already there for popping and pushing from the front.
    
    @bors: r+ 38fe8d2 rollup
    Chris Couzens committed Dec 10, 2018
    Configuration menu
    Copy the full SHA
    562f33b View commit details
    Browse the repository at this point in the history
  2. bootstrap: fix edition

    ljedrz committed Dec 10, 2018
    Configuration menu
    Copy the full SHA
    a5a3da5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a336228 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ecc4ca5 View commit details
    Browse the repository at this point in the history
  5. Add trailing newline

    aelred committed Dec 10, 2018
    Configuration menu
    Copy the full SHA
    3246f49 View commit details
    Browse the repository at this point in the history
  6. reject invalid external doc attributes

    Also, provide a suggestion for the correct syntax.
    euclio committed Dec 10, 2018
    Configuration menu
    Copy the full SHA
    c3c2de9 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    7f7045f View commit details
    Browse the repository at this point in the history
  8. fix install broken link

    mishaker committed Dec 10, 2018
    Configuration menu
    Copy the full SHA
    3d23e55 View commit details
    Browse the repository at this point in the history
  9. Add lint for stlib

    aheart committed Dec 10, 2018
    Configuration menu
    Copy the full SHA
    f8c03b6 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2018

  1. Configuration menu
    Copy the full SHA
    771e8b8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    799cadb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1346619 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5457b19 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    510a9ff View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    30f531b View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    8ee2c06 View commit details
    Browse the repository at this point in the history
  8. Test capacity of ZST vector

    Initially, rust-lang#50233 accidentally changed the capacity of empty ZST. This
    was pointed out during code review. This commit adds a test to prevent
    capacity of ZST vectors from accidentally changing to prevent that
    from happening again.
    KamilaBorowska committed Dec 11, 2018
    Configuration menu
    Copy the full SHA
    1006425 View commit details
    Browse the repository at this point in the history
  9. Always set the RDRAND and RDSEED features on SGX

    Jethro Beekman committed Dec 11, 2018
    Configuration menu
    Copy the full SHA
    5acab2d View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    45b97f2 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    b17a3f2 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    8e994a2 View commit details
    Browse the repository at this point in the history
  13. Use a newtype_index! within Symbol.

    This shrinks `Option<Symbol>` from 8 bytes to 4 bytes, which shrinks
    `Token` from 24 bytes to 16 bytes. This reduces instruction counts by up
    to 1% across a range of benchmarks.
    nnethercote committed Dec 11, 2018
    Configuration menu
    Copy the full SHA
    0f68749 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    b96186b View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2018

  1. Configuration menu
    Copy the full SHA
    517bfe0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    76cb35e View commit details
    Browse the repository at this point in the history
  3. Add test of current behavior (infer free region within closure body) …

    …previously not in test suite.
    pnkfelix committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    29e7ca9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    29bec2d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    8b67eb8 View commit details
    Browse the repository at this point in the history
  6. x86: Add the adx target feature to whitelist

    Requested in rust-lang/stdarch#322 this is hopefully the first
    step!
    alexcrichton committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    78f20de View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    0008e0d View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    b9235ea View commit details
    Browse the repository at this point in the history
  9. Disable btree pretty-printers on older gdbs

    gdb versions before 8.1 have a bug that prevents the BTreeSet and
    BTreeMap pretty-printers from working.  This patch disables the test
    on those versions, and also disables the pretty-printers there as
    well.
    
    Closes rust-lang#56730
    tromey committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    4007adf View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    ae893bb View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2018

  1. Stabilize linker-flavor flag.

    This commit moves the linker-flavor flag from a debugging option to a
    codegen option, thus stabilizing it. There are no feature flags
    associated with this flag.
    davidtwco committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    9536d04 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#56142 - jnqnfe:osstr_lossy_example, r=alexc…

    …richton
    
    [std] Osstr lossy example
    kennytm committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    1c50470 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#56203 - aheart:master, r=varkor

    Add lint for items deprecated in future
    
    Resolves rust-lang#55892
    kennytm committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    94f5211 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#56343 - yui-knk:remove_mir_stats_mod, r=nik…

    …omatsakis
    
    Remove not used mod
    
    `mir_stats` mod has not been used since c1ff104.
    kennytm committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    3085f03 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#56439 - JohnGinger:master, r=nikomatsakis

    Clearer error message for dead assign
    
    I'm not that this is the right place for this (if it needs an RFC or not).
    
    I had the problem where I misunderstood the compiler lint message rust-lang#56436 and other people seem to have had the same problem https://www.reddit.com/r/rust/comments/8cy9p4/value_assigned_to_is_never_read/.
    
    I think this new wording might be slightly clearer (and help out beginners like me). I'm very new though, so there might be some nuance I'm missing that would make this more confusing or a bad idea for other reasons.
    
    I thought I would create a PR to make it easy to change the code if the consensus was that it would make sense to make a change.
    
    If this is the wrong place for this sort of thing I'll happily delete/move it.
    kennytm committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    0efd522 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#56507 - nikomatsakis:polonius-integrate, r=…

    …MatthewJasper
    
    polonius tweaks
    
    - bump polonius to 0.6.0
    - fix 2-phase-borrow activations
    
    r? @matthewjasper
    kennytm committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    6fb3eb3 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#56600 - ljedrz:fix_edition, r=Mark-Simulacrum

    bootstrap: fix edition
    
    A byproduct of work on rust-lang#56595; done with `cargo fix --edition`.
    kennytm committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    3cff3f6 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#56609 - michaelwoerister:unconditional-targ…

    …et-cpu-attr, r=alexcrichton
    
    Unconditionally emit the target-cpu LLVM attribute.
    
    This PR makes `rustc` always emit the `target-cpu` LLVM attribute for functions. The goal is to allow for cross-language inlining of functions defined in `libstd`. So far `libstd` functions were the only function without a `target-cpu` attribute, so in whole-crate-graph cross-lang LTO scenarios they were not eligible for inlining into foreign code.
    
    r? @alexcrichton
    kennytm committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    3df7a92 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#56637 - ollie27:rustdoc_proc_macro_local_re…

    …export, r=QuietMisdreavus
    
    rustdoc: Fix local reexports of proc macros
    
    Filter out `ProcMacroStub`s to avoid an ICE during cleaning.
    
    Also add proc macros to `cache().paths` so it can generate links.
    
    r? @QuietMisdreavus
    kennytm committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    3114725 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#56658 - Xanewok:non-panicking-file-parser, …

    …r=petrochenkov
    
    Add non-panicking `maybe_new_parser_from_file` variant
    
    Add (seemingly?) missing `maybe_new_parser_from_file` constructor variant.
    
    Disclaimer: I'm not certain this is the correct approach - just found out we don't have this when working on a Rustfmt PR to catch/prevent more Rust parser panics: rust-lang/rustfmt#3240 and tried to make it work somehow.
    kennytm committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    43e19e9 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#56672 - ccouzens:master, r=nikic

    Document time of back operations of a Linked List
    
    Popping and pushing from the end of a linked list is constant time. This
    documentation is already there for popping and pushing from the front.
    
    @bors: r+ 38fe8d2 rollup
    kennytm committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    73236ad View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#56677 - aelred:must-use-on-traits, r=estebank

    #[must_use] on traits in stdlib
    
    Based on rust-lang#55506.
    
    Adds `#[must_use]` attribute to traits in the stdlib:
    - `Iterator`
    - `Future`
    - `FnOnce`
    - `Fn`
    - `FnMut`
    
    There may be other traits that should have the attribute, but I couldn't find/think of any.
    kennytm committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    5168289 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#56679 - euclio:external-doc-parse, r=estebank

    overhaul external doc attribute diagnostics
    
    This PR improves the error handling and spans for the external doc attribute. Many cases that silently failed before now emit errors, spans are tightened, and the errors have help and suggestions.
    
    I tried to address all the cases that users ran into in the tracking issue.
    
    cc rust-lang#44732
    
    r? @QuietMisdreavus
    kennytm committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    d43d922 View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#56691 - mishaker:fix_doc_install_broken_lin…

    …k, r=jonas-schievink
    
    fix install broken link
    
    solves rust-lang#56690
    kennytm committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    3783c70 View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#56695 - varkor:let-exhaustive-range, r=este…

    …bank
    
    Fix irrefutable matches on integer ranges
    
    Fixes rust-lang#56659.
    kennytm committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    c8541c2 View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#56699 - nnethercote:SymbolIndex, r=oli-obk

    Use a `newtype_index!` within `Symbol`.
    
    This shrinks `Option<Symbol>` from 8 bytes to 4 bytes, which shrinks
    `Token` from 24 bytes to 16 bytes. This reduces instruction counts by up
    to 1% across a range of benchmarks.
    
    r? @oli-obk
    kennytm committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    d82b64c View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#56702 - wesleywiser:calc_total_time_stats, …

    …r=michaelwoerister
    
    [self-profiler] Add column for percent of total time
    
    Example output:
    
    ```
    Self profiling results:
    
    | Phase            | Time (ms)      | Time (%) | Queries        | Hits (%)
    | ---------------- | -------------- | -------- | -------------- | --------
    | Parsing          | 3              | 0.52     |                |
    | Expansion        | 64             | 11.27    |                |
    | TypeChecking     | 13             | 2.36     | 35208          | 90.77
    | BorrowChecking   | 0              | 0.10     | 68             | 50.00
    | Codegen          | 22             | 3.82     | 7362           | 75.12
    | Linking          | 252            | 43.81    | 458            | 68.56
    | Other            | 219            | 38.12    | 47372          | 56.84
    
    Optimization level: No
    Incremental: off
    
    ```
    
    cc @michaelwoerister
    kennytm committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    d0647ec View commit details
    Browse the repository at this point in the history
  18. Rollup merge of rust-lang#56708 - oli-obk:stability_internal_const_fn…

    …, r=alexcrichton
    
    Remove some unnecessary feature gates
    
    fixes rust-lang#56585
    
    cc @jethrogb
    kennytm committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    070443b View commit details
    Browse the repository at this point in the history
  19. Rollup merge of rust-lang#56710 - jethrogb:jb/sgx-target-features, r=…

    …alexcrichton
    
    Always set the RDRAND and RDSEED features on SGX
    
    Not sure if this is 100% correct.
    
    This [Intel article](https://software.intel.com/en-us/articles/intel-software-guard-extensions-tutorial-part-5-enclave-development) goes in great depth regarding using (untrusted) CPUID to see whether RDRAND/RDSEED is supported, and explains what happens to the enclave if the CPUID result is faked.
    
    I'd say that an implementation of SGX that doesn't make RDRAND available to the enclave is so severely limited/broken that it's ok if you get #UD in that case. The case is less clear for RDSEED, but it so far every processor released by Intel with SGX support also has RDSEED (including Gemini Lake).
    
    cc @briansmith
    kennytm committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    d09aefb View commit details
    Browse the repository at this point in the history
  20. Rollup merge of rust-lang#56713 - xfix:vec-test-zst-capacity, r=TimNN

    Test capacity of ZST vector
    
    Initially, rust-lang#50233 accidentally changed the capacity of empty ZST. This was pointed out during code review. This commit adds a test to prevent capacity of ZST vectors from accidentally changing to prevent that from happening again.
    kennytm committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    084e873 View commit details
    Browse the repository at this point in the history
  21. Rollup merge of rust-lang#56718 - RalfJung:use-libbacktrace-printing,…

    … r=alexcrichton
    
    Use libbacktrace pretty-printing
    
    r? @alexcrichton
    kennytm committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    f7889e1 View commit details
    Browse the repository at this point in the history
  22. Rollup merge of rust-lang#56725 - piersfinlayson:master, r=alexcrichton

    fix rust-lang/rust issue rust-lang#50583
    
    Rationale for the fix is in rust-lang#50583.  I've verified that before the fix /musl-armhf/lib/libc.a is riddled with the illegal variant of vmov.f64 and after the fix the version built doesn't contain any of these illegal instructions.
    
    I originally thought that the arm-linux-gnueabi version also needed fixing - to add a -mfloat-abi-soft but that's unnecessary as it's compiled with the gnueabi (not hf) compiler (I've some a quick check that the libc.a produced doesn't include VFP instructions).
    
    r? @alexcrichton
    kennytm committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    8ca6266 View commit details
    Browse the repository at this point in the history
  23. Rollup merge of rust-lang#56731 - GuillaumeGomez:ffi-doc-urls, r=Centril

    Add missing urls in ffi module docs
    
    r? @QuietMisdreavus
    kennytm committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    ded6435 View commit details
    Browse the repository at this point in the history
  24. Rollup merge of rust-lang#56738 - turboladen:fix-private_no_mangle_fn…

    …s-message, r=zackmdavis
    
    Fix private_no_mangle_fns message grammar
    
    Simply changes "an warning" to "a warning" in the `private_no_mangle_fns` warning. I started getting this in some code after upgrading to 1.31.0.
    kennytm committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    1818c31 View commit details
    Browse the repository at this point in the history
  25. Rollup merge of rust-lang#56742 - ljedrz:remove_query_response_box, r…

    …=oli-obk
    
    infer: remove Box from a returned Iterator
    kennytm committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    802409f View commit details
    Browse the repository at this point in the history
  26. Rollup merge of rust-lang#56746 - pnkfelix:issue-56537-add-test-of-cl…

    …osure-using-region-from-containing-fn, r=nikomatsakis
    
    Add test of current behavior (infer free region within closure body)
    
    This behavior was previously not encoded in our test suite.
    
    it is pretty important that we test this behavior. In particular, in rust-lang#56537  I had proposed expanding the lifetime elision rules so that they would apply to some of the cases encoded in this test, which would cause them to start failing to compile successfully (because the lifetime attached to the return type would start being treated as connected to the lifetime on the input parameter to the lambda expression, which is explicitly *not* what the code wants in this particular case).
    
    In other words, I am trying to ensure that anyone who tries such experiments with lifetime elision in the future quickly finds out why we don't support lifetime elision on lambda expressions (at least not in the naive manner described on rust-lang#56537).
    kennytm committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    5443a69 View commit details
    Browse the repository at this point in the history
  27. Rollup merge of rust-lang#56747 - ljedrz:remove_box_from_target, r=za…

    …ckmdavis
    
    target: remove Box returned by get_targets
    kennytm committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    35f987f View commit details
    Browse the repository at this point in the history
  28. Rollup merge of rust-lang#56749 - alexcrichton:adx, r=gnzlbg

    x86: Add the `adx` target feature to whitelist
    
    Requested in rust-lang/stdarch#322 this is hopefully the first
    step!
    kennytm committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    03b3d6f View commit details
    Browse the repository at this point in the history
  29. Rollup merge of rust-lang#56755 - estebank:impl-trait-lt-sugg, r=cram…

    …ertj
    
    Account for `impl Trait` when suggesting lifetime
    
    Fix rust-lang#56745
    kennytm committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    d775331 View commit details
    Browse the repository at this point in the history
  30. Rollup merge of rust-lang#56756 - tromey:Bug-56730-btree-pretty-print…

    …er, r=alexcrichton
    
    Disable btree pretty-printers on older gdbs
    
    gdb versions before 8.1 have a bug that prevents the BTreeSet and
    BTreeMap pretty-printers from working.  This patch disables the test
    on those versions, and also disables the pretty-printers there as
    well.
    
    Closes rust-lang#56730
    kennytm committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    d979632 View commit details
    Browse the repository at this point in the history
  31. Rollup merge of rust-lang#56562 - pnkfelix:issue-55465-update-libc-ve…

    …rsion, r=alexcrichton
    
    Update libc version required by rustc
    
    This is meant to be an easy-to-backport fix for rust-lang#55465
    kennytm committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    055e288 View commit details
    Browse the repository at this point in the history
  32. Rollup merge of rust-lang#56351 - davidtwco:issue-55396-stabilize-lin…

    …ker-flavor, r=nagisa
    
    Stabilize `linker-flavor` flag.
    
    Part of rust-lang#55396.
    
    This commit moves the linker-flavor flag from a debugging option to a
    codegen option, thus stabilizing it. There are no feature flags
    associated with this flag.
    kennytm committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    85fc7af View commit details
    Browse the repository at this point in the history
  33. Rollup merge of rust-lang#56758 - Manishearth:emoji-status-toolstate,…

    … r=kennytm
    
    Add short emoji status to toolstate updates
    
    I get a lot of these emails and it's good to know which ones I should be paying closer attention to -- i.e. the ones where clippy breaks. This adds a short emoji status report to the first line of the commit message, which shows up in notifications directly
    
    I haven't been able to test it, and the actual emoji are just suggestions.
    kennytm committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    8caa657 View commit details
    Browse the repository at this point in the history