Upgrade x86_64-fortanix-unknown-sgx platform support to tier 2 #57130

VardhanThigle · 2018-12-26T12:48:18Z

Overview

This PR upgrades x86_64-fortanix-unknown-sgx platform support to tier 2 (std only) by setting up build automation for this target.
For supporting unwinding, this target needs to link to a port of LLVM's libunwind (more details could be found in Adding unwinding support for x86_64_fortanix_unknown_sgx target. #56979), which will be distributed along with the Rust binaries (similar to the extra musl objects)

Building and copying libunwind:

We have added a new build script (build-x86_64-fortanix-unknown-sgx-toolchain.sh) that will run while the container is built. This will build libunwind.a from git source.
While the container is built, the persistent volumes where obj/ gets created aren't yet mapped. As a workaround, we copy the built libunwind.a to obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-fortanix-unknown-sgx/lib/ after x.py runs.
If any reviewer knows of a better solution, please do tell.

r? @Mark-Simulacrum

rust-highfive · 2018-12-26T12:48:28Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

jethrogb · 2018-12-26T13:00:43Z

I assume that if and when this PR gets merged, it will end up riding the release train all the way to stable? Is there a way to prevent that and only produce std artifacts on nightly? We're not yet ready to declare the binaries that are produced by this target stable, as in, the binary format might change.

jethrogb · 2019-01-09T07:51:24Z

This was discussed in triage yesterday. There is currently no mechanism to prevent this from getting into stable. However, the infra team felt that artifact compatibility was not a Rust concern, but a platform concern. We agree and are fine with this making it into stable. This PR now adds a platform-specific toolchain version number that may used by the platform to detect incompatibilities.

This PR is now ready for review.

VardhanThigle · 2019-01-10T15:06:14Z

@Mark-Simulacrum Please let me know if there is anything blocking your review.

Mark-Simulacrum · 2019-01-11T00:12:02Z

src/ci/docker/dist-various-2/build-x86_64-fortanix-unknown-sgx-toolchain.sh

+
+    # Clone LLVM and libunwind
+    # libunwind cmake build needs cmake configuration from LLVM.
+    git clone --depth 1 https://github.com/llvm-mirror/llvm.git


Hm, could we perhaps reuse the existing llvm submodule (src/llvm)? If not, a comment here why not would be good.

Cloning llvm twice wouldn't really be ideal (it takes a while to do so on CI)

@Mark-Simulacrum
We found a way to use existing LLVM. Please let us know what you think about the current approach.

Mark-Simulacrum · 2019-01-11T00:12:57Z

src/ci/docker/dist-various-2/build-x86_64-fortanix-unknown-sgx-toolchain.sh

+    #Build Unwind
+    mkdir -p build
+    cd build
+    cmake -DCMAKE_BUILD_TYPE="RELEASE" -DRUST_SGX=1 -G "Unix Makefiles" -DLLVM_PATH=../../llvm/ ../


To be clear, this doesn't build LLVM, correct?

Correct. It does not build llvm. In fact, it needs only llvm/cmake.

rust-highfive · 2019-01-11T13:36:51Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:043077f6:start=1547211753981144823,finish=1547211756129483677,duration=2148338854
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---

[00:04:02] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:04:02] tidy error: /checkout/src/ci/docker/run.sh:40: line longer than 100 chars
[00:04:02] tidy error: /checkout/src/ci/docker/dist-various-2/prepare-context.sh:4: trailing whitespace
[00:04:03] some tidy checks failed
[00:04:03] 
[00:04:03] 
[00:04:03] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:04:03] 
[00:04:03] 
[00:04:03] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:04:03] Build completed unsuccessfully in 0:00:49
[00:04:03] Build completed unsuccessfully in 0:00:49
[00:04:03] Makefile:69: recipe for target 'tidy' failed
[00:04:03] make: *** [tidy] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:1df1ff94
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Fri Jan 11 13:06:50 UTC 2019
---
travis_time:end:049af1c8:start=1547212011602729115,finish=1547212011607327447,duration=4598332
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:15d71b84
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0163a38b
travis_time:start:0163a38b
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:1898b97c
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Mark-Simulacrum · 2019-01-11T14:03:16Z

Seems okay to me but I'm wondering if @alexcrichton might have a better idea for how to do it - loosely I believe we're already doing something like this somewhere but I don't remember where :)

r? @alexcrichton

VardhanThigle · 2019-01-11T16:07:44Z

Fixed tidy issues in my previous push.

alexcrichton

This looks fine to me, but I think it's worthwhile to clean up the docker/scripts a bit.

To be clear, "tier 2" nowadays is "we produces binaries on a best-effort basis". As with all other platforms we reserve the right to turn this off at any point in time to land otherwise critical changes to the standard library. In practice we've only done this once or twice (adding u128 and disabling some targets is what comes to mind), but I just want to make sure that it's explicit that we're not going to provide a long-term guarantee that this target is available one every single nightly in the future.

alexcrichton · 2019-01-11T17:36:57Z

src/ci/docker/dist-various-2/Dockerfile


 ENV RUST_CONFIGURE_ARGS --enable-extended --enable-lld --disable-docs
-ENV SCRIPT python2.7 ../x.py dist --target $TARGETS
+ENV SCRIPT python2.7 ../x.py dist --target $TARGETS && \
+         cp /x86_64_fortanix_unknown_sgx/lib/* /checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-fortanix-unknown-sgx/lib/


Can this be done by rustbuild instead of having to manually add it here?

Could you provide any pointers on how to do this?

You can look around rustbuild for things like rsend.o and mingw, that platform and musl already copy files around like this.

In my current push, I have followed the copy_thrid_party_objects logic for musl.
For this target, the Docker build process sets and ENV variable indicating source path of the libunwind.a. The boot strap code reads the same and copies the file to correct destination.

alexcrichton · 2019-01-11T17:37:56Z

src/ci/docker/run.sh

@@ -37,6 +37,9 @@ if [ -f "$docker_dir/$image/Dockerfile" ]; then
      echo "Downloaded containers:\n$loaded_images"
    fi

+    prepare_context="${docker_dir}/${image}/prepare-context.sh"


This seems a bit overly magical, could the LLVM sources just be downloaded in the container?

Ok. @Mark-Simulacrum specifically requested this change. Review c5c09da2c1f89f19554f3bfaff09f48decba25cb if you want that behavior.

That was a comment about reusing git commits, which may be nice to use but I don't think it should require magical scripts like this. Everything about docker layers is already cached, so it's best to just go ahead and download separately here as it likely doesn't need the exact same revision of LLVM we use anyway.

I also missed that this was in the setup for the docker containers so thought it wouldn't be cached.

We have reverted the changes to copy existing llvm/cmake into the container.
Also, 2 days back, llvm-project transitioned to monorepo. Accordingly, we have moved our libunwind changes to Fortanix's fork of the llvm-project.
In the recent push, we are using the same to build libunwind.a.
To optimise the docker build time, we are downloading source of the specific commit we need from the above port. The implementation to do the same is based on fetch_submodule from init_repo.sh)

VardhanThigle · 2019-01-13T06:47:39Z

Thanks for the review comments @alexcrichton and @Mark-Simulacrum.
In my current push, I have incorporated the review comments:

Download llvm (source for a specific commit) while building CI container.
copy libunwind.a needed by this target as a part of rust build process.
Please let us know what you think about the current approach followed here.

jethrogb · 2019-01-13T07:17:13Z

src/ci/docker/dist-various-2/Dockerfile

@@ -65,6 +70,10 @@ ENV TARGETS=$TARGETS,wasm32-unknown-unknown
 ENV TARGETS=$TARGETS,x86_64-sun-solaris
 ENV TARGETS=$TARGETS,x86_64-unknown-linux-gnux32
 ENV TARGETS=$TARGETS,x86_64-unknown-cloudabi
+ENV TARGETS=$TARGETS,x86_64-fortanix-unknown-sgx
+ENV TARGETS=x86_64-fortanix-unknown-sgx


I think this is not correct

Thanks for the review. I had added it for faster testing. Forgot to remove it.
Pushed the fix.

jethrogb · 2019-01-13T07:21:42Z

src/bootstrap/compile.rs

@@ -114,19 +108,39 @@ impl Step for Std {
            target,
        });
    }
+


stray newline

Fixed in current push.

jethrogb · 2019-01-13T07:21:51Z

src/ci/docker/dist-various-2/Dockerfile


 COPY scripts/sccache.sh /scripts/
 RUN sh /scripts/sccache.sh

+


stray newline

Fixed in current push.

alexcrichton · 2019-01-14T17:47:05Z

@bors: r+

bors · 2019-01-14T17:47:07Z

📌 Commit 99fbd1b has been approved by alexcrichton

bors · 2019-01-15T04:06:35Z

⌛ Testing commit 99fbd1b with merge 33e6df4...

@Mark-Simulacrum

…sgx-tier2_support, r=alexcrichton Upgrade x86_64-fortanix-unknown-sgx platform support to tier 2 ## Overview 1. This PR upgrades x86_64-fortanix-unknown-sgx platform support to tier 2 (std only) by setting up build automation for this target. 1. For supporting unwinding, this target needs to link to a port of LLVM's libunwind (more details could be found in #56979), which will be distributed along with the Rust binaries (similar to the extra musl objects) ### Building and copying libunwind: We have added a new build script (`build-x86_64-fortanix-unknown-sgx-toolchain.sh`) that will run while the container is built. This will build `libunwind.a` from git source. While the container is built, the persistent volumes where obj/ gets created aren't yet mapped. As a workaround, we copy the built `libunwind.a` to `obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-fortanix-unknown-sgx/lib/` after x.py runs. If any reviewer knows of a better solution, please do tell. r? @Mark-Simulacrum

bors · 2019-01-15T06:41:34Z

☀️ Test successful - checks-travis, status-appveyor
Approved by: alexcrichton
Pushing 33e6df4 to master...

Pkgsrc changes: * Bump required rust version to build to 1.32.0. * Adapt patches to changed file locations. * Since we now patch some more vendor/ modules, doctor the corresponding .cargo-checksum.json files accordingly Upstream changes: Version 1.33.0 (2019-02-28) ========================== Language -------- - [You can now use the `cfg(target_vendor)` attribute.][57465] E.g. `#[cfg(target_vendor="apple")] fn main() { println!("Hello Apple!"); }` - [Integer patterns such as in a match expression can now be exhaustive.][56362] E.g. You can have match statement on a `u8` that covers `0..=255` and you would no longer be required to have a `_ => unreachable!()` case. - [You can now have multiple patterns in `if let` and `while let` expressions.][57532] You can do this with the same syntax as a `match` expression. E.g. ```rust enum Creature { Crab(String), Lobster(String), Person(String), } fn main() { let state = Creature::Crab("Ferris"); if let Creature::Crab(name) | Creature::Person(name) = state { println!("This creature's name is: {}", name); } } ``` - [You can now have irrefutable `if let` and `while let` patterns.][57535] Using this feature will by default produce a warning as this behaviour can be unintuitive. E.g. `if let _ = 5 {}` - [You can now use `let` bindings, assignments, expression statements, and irrefutable pattern destructuring in const functions.][57175] - [You can now call unsafe const functions.][57067] E.g. ```rust const unsafe fn foo() -> i32 { 5 } const fn bar() -> i32 { unsafe { foo() } } ``` - [You can now specify multiple attributes in a `cfg_attr` attribute.][57332] E.g. `#[cfg_attr(all(), must_use, optimize)]` - [You can now specify a specific alignment with the `#[repr(packed)]` attribute.][57049] E.g. `#[repr(packed(2))] struct Foo(i16, i32);` is a struct with an alignment of 2 bytes and a size of 6 bytes. - [You can now import an item from a module as an `_`.][56303] This allows you to import a trait's impls, and not have the name in the namespace. E.g. ```rust use std::io::Read as _; // Allowed as there is only one `Read` in the module. pub trait Read {} ``` - [You may now use `Rc`, `Arc`, and `Pin` as method receivers][56805]. Compiler -------- - [You can now set a linker flavor for `rustc` with the `-Clinker-flavor` command line argument.][56351] - [The mininum required LLVM version has been bumped to 6.0.][56642] - [Added support for the PowerPC64 architecture on FreeBSD.][57615] - [The `x86_64-fortanix-unknown-sgx` target support has been upgraded to tier 2 support.][57130] Visit the [platform support][platform-support] page for information on Rust's platform support. - [Added support for the `thumbv7neon-linux-androideabi` and `thumbv7neon-unknown-linux-gnueabihf` targets.][56947] - [Added support for the `x86_64-unknown-uefi` target.][56769] Libraries --------- - [The methods `overflowing_{add, sub, mul, shl, shr}` are now `const` functions for all numeric types.][57566] - [The methods `rotate_left`, `rotate_right`, and `wrapping_{add, sub, mul, shl, shr}` are now `const` functions for all numeric types.][57105] - [The methods `is_positive` and `is_negative` are now `const` functions for all signed numeric types.][57105] - [The `get` method for all `NonZero` types is now `const`.][57167] - [The methods `count_ones`, `count_zeros`, `leading_zeros`, `trailing_zeros`, `swap_bytes`, `from_be`, `from_le`, `to_be`, `to_le` are now `const` for all numeric types.][57234] - [`Ipv4Addr::new` is now a `const` function][57234] Stabilized APIs --------------- - [`unix::FileExt::read_exact_at`] - [`unix::FileExt::write_all_at`] - [`Option::transpose`] - [`Result::transpose`] - [`convert::identity`] - [`pin::Pin`] - [`marker::Unpin`] - [`marker::PhantomPinned`] - [`Vec::resize_with`] - [`VecDeque::resize_with`] - [`Duration::as_millis`] - [`Duration::as_micros`] - [`Duration::as_nanos`] Cargo ----- - [Cargo should now rebuild a crate if a file was modified during the initial build.][cargo/6484] Compatibility Notes ------------------- - The methods `str::{trim_left, trim_right, trim_left_matches, trim_right_matches}` are now deprecated in the standard library, and their usage will now produce a warning. Please use the `str::{trim_start, trim_end, trim_start_matches, trim_end_matches}` methods instead. - The `Error::cause` method has been deprecated in favor of `Error::source` which supports downcasting. [55982]: rust-lang/rust#55982 [56303]: rust-lang/rust#56303 [56351]: rust-lang/rust#56351 [56362]: rust-lang/rust#56362 [56642]: rust-lang/rust#56642 [56769]: rust-lang/rust#56769 [56805]: rust-lang/rust#56805 [56947]: rust-lang/rust#56947 [57049]: rust-lang/rust#57049 [57067]: rust-lang/rust#57067 [57105]: rust-lang/rust#57105 [57130]: rust-lang/rust#57130 [57167]: rust-lang/rust#57167 [57175]: rust-lang/rust#57175 [57234]: rust-lang/rust#57234 [57332]: rust-lang/rust#57332 [57465]: rust-lang/rust#57465 [57532]: rust-lang/rust#57532 [57535]: rust-lang/rust#57535 [57566]: rust-lang/rust#57566 [57615]: rust-lang/rust#57615 [cargo/6484]: rust-lang/cargo#6484 [`unix::FileExt::read_exact_at`]: https://doc.rust-lang.org/std/os/unix/fs/trait.FileExt.html#method.read_exact_at [`unix::FileExt::write_all_at`]: https://doc.rust-lang.org/std/os/unix/fs/trait.FileExt.html#method.write_all_at [`Option::transpose`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.transpose [`Result::transpose`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.transpose [`convert::identity`]: https://doc.rust-lang.org/std/convert/fn.identity.html [`pin::Pin`]: https://doc.rust-lang.org/std/pin/struct.Pin.html [`marker::Unpin`]: https://doc.rust-lang.org/stable/std/marker/trait.Unpin.html [`marker::PhantomPinned`]: https://doc.rust-lang.org/nightly/std/marker/struct.PhantomPinned.html [`Vec::resize_with`]: https://doc.rust-lang.org/std/vec/struct.Vec.html#method.resize_with [`VecDeque::resize_with`]: https://doc.rust-lang.org/std/collections/struct.VecDeque.html#method.resize_with [`Duration::as_millis`]: https://doc.rust-lang.org/std/time/struct.Duration.html#method.as_millis [`Duration::as_micros`]: https://doc.rust-lang.org/std/time/struct.Duration.html#method.as_micros [`Duration::as_nanos`]: https://doc.rust-lang.org/std/time/struct.Duration.html#method.as_nanos [platform-support]: https://forge.rust-lang.org/platform-support.html

rust-highfive assigned Mark-Simulacrum Dec 26, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 26, 2018

VardhanThigle force-pushed the Vardhan/x86_64-fortanix-unknown-sgx-tier2_support branch from c7f482f to 0db5003 Compare December 26, 2018 13:03

Mark-Simulacrum added I-nominated T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Dec 26, 2018

VardhanThigle force-pushed the Vardhan/x86_64-fortanix-unknown-sgx-tier2_support branch from 0db5003 to d38d1e8 Compare January 9, 2019 07:50

Mark-Simulacrum reviewed Jan 11, 2019

View reviewed changes

VardhanThigle force-pushed the Vardhan/x86_64-fortanix-unknown-sgx-tier2_support branch from 9555642 to 24742f0 Compare January 11, 2019 13:01

rust-highfive assigned alexcrichton and unassigned Mark-Simulacrum Jan 11, 2019

VardhanThigle force-pushed the Vardhan/x86_64-fortanix-unknown-sgx-tier2_support branch from 24742f0 to b107c5b Compare January 11, 2019 16:03

alexcrichton reviewed Jan 11, 2019

View reviewed changes

VardhanThigle force-pushed the Vardhan/x86_64-fortanix-unknown-sgx-tier2_support branch from b107c5b to fb83884 Compare January 13, 2019 06:42

jethrogb reviewed Jan 13, 2019

View reviewed changes

VardhanThigle force-pushed the Vardhan/x86_64-fortanix-unknown-sgx-tier2_support branch from fb83884 to dab6b89 Compare January 13, 2019 07:30

Vardhan Thigle added 2 commits January 13, 2019 13:07

Adding Build automation for x86_64-fortanix-unknown-sgx

4a957b3

Fix breakage from rust-lang#56988 and workaround for rust-lang#57569

99fbd1b

VardhanThigle force-pushed the Vardhan/x86_64-fortanix-unknown-sgx-tier2_support branch from dab6b89 to 99fbd1b Compare January 13, 2019 07:37

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 14, 2019

bors merged commit 99fbd1b into rust-lang:master Jan 15, 2019

jethrogb mentioned this pull request Jan 18, 2019

Upgrade platform support to tier 2 fortanix/rust-sgx#44

Closed

aidanhs removed the I-nominated label Feb 4, 2019

Centril added this to the 1.33 milestone Apr 26, 2019

jethrogb mentioned this pull request Nov 6, 2019

Target tier policy rust-lang/rfcs#2803

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade x86_64-fortanix-unknown-sgx platform support to tier 2 #57130

Upgrade x86_64-fortanix-unknown-sgx platform support to tier 2 #57130

VardhanThigle commented Dec 26, 2018 •

edited

Loading

rust-highfive commented Dec 26, 2018

jethrogb commented Dec 26, 2018

jethrogb commented Jan 9, 2019

VardhanThigle commented Jan 10, 2019 •

edited

Loading

Mark-Simulacrum Jan 11, 2019

VardhanThigle Jan 11, 2019

Mark-Simulacrum Jan 11, 2019

VardhanThigle Jan 11, 2019

rust-highfive commented Jan 11, 2019

Mark-Simulacrum commented Jan 11, 2019

VardhanThigle commented Jan 11, 2019

alexcrichton left a comment

alexcrichton Jan 11, 2019

jethrogb Jan 11, 2019

alexcrichton Jan 12, 2019

VardhanThigle Jan 13, 2019

alexcrichton Jan 11, 2019

jethrogb Jan 11, 2019

alexcrichton Jan 12, 2019

Mark-Simulacrum Jan 12, 2019

VardhanThigle Jan 13, 2019 •

edited

Loading

VardhanThigle commented Jan 13, 2019

jethrogb Jan 13, 2019

VardhanThigle Jan 13, 2019

jethrogb Jan 13, 2019

VardhanThigle Jan 13, 2019

jethrogb Jan 13, 2019

VardhanThigle Jan 13, 2019

alexcrichton commented Jan 14, 2019

bors commented Jan 14, 2019

bors commented Jan 15, 2019

bors commented Jan 15, 2019

@@ @@ -114,19 +108,39 @@ impl Step for Std { @@
                           target,
                       });
                   }

Upgrade x86_64-fortanix-unknown-sgx platform support to tier 2 #57130

Upgrade x86_64-fortanix-unknown-sgx platform support to tier 2 #57130

Conversation

VardhanThigle commented Dec 26, 2018 • edited Loading

Overview

Building and copying libunwind:

rust-highfive commented Dec 26, 2018

jethrogb commented Dec 26, 2018

jethrogb commented Jan 9, 2019

VardhanThigle commented Jan 10, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rust-highfive commented Jan 11, 2019

Mark-Simulacrum commented Jan 11, 2019

VardhanThigle commented Jan 11, 2019

alexcrichton left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

VardhanThigle Jan 13, 2019 • edited Loading

Choose a reason for hiding this comment

VardhanThigle commented Jan 13, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alexcrichton commented Jan 14, 2019

bors commented Jan 14, 2019

bors commented Jan 15, 2019

bors commented Jan 15, 2019

VardhanThigle commented Dec 26, 2018 •

edited

Loading

VardhanThigle commented Jan 10, 2019 •

edited

Loading

VardhanThigle Jan 13, 2019 •

edited

Loading