Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aggregation of drive-by cosmetic changes for trait-upcasting PR #66610

Merged
merged 2 commits into from
Nov 22, 2019
Merged

Aggregation of drive-by cosmetic changes for trait-upcasting PR #66610

merged 2 commits into from
Nov 22, 2019

Conversation

alexreg
Copy link
Contributor

@alexreg alexreg commented Nov 21, 2019

Cherry-picked from #60900.

As requested by @Centril (and @nikomatsakis, I believe).

r? @Centril

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 21, 2019
@bors

This comment has been minimized.

Sign in to view
Centril
Centril reviewed Nov 21, 2019
View reviewed changes
src/librustc/traits/auto_trait.rs Outdated Show resolved Hide resolved
src/librustc/traits/auto_trait.rs Show resolved Hide resolved
src/librustc/traits/auto_trait.rs Show resolved Hide resolved
src/librustc/traits/auto_trait.rs Show resolved Hide resolved
src/librustc/traits/mod.rs Outdated Show resolved Hide resolved
src/librustc_codegen_llvm/debuginfo/metadata.rs Outdated Show resolved Hide resolved
src/librustc_codegen_llvm/debuginfo/metadata.rs Show resolved Hide resolved
src/librustc_codegen_llvm/debuginfo/metadata.rs Outdated Show resolved Hide resolved
src/librustc_codegen_llvm/debuginfo/metadata.rs Outdated Show resolved Hide resolved
src/librustc_mir/monomorphize/collector.rs Show resolved Hide resolved
@Centril
Copy link
Contributor

Centril commented Nov 21, 2019 •
edited
Loading

Thanks; r=me with comments ^--- addressed.

@Centril Centril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 21, 2019
@Centril
Copy link
Contributor

Centril commented Nov 21, 2019

Fairly bit-rotty; @bors p=1

@alexreg
Copy link
Contributor Author

alexreg commented Nov 21, 2019

@bors r=Centril p=1

@bors
Copy link
Contributor

bors commented Nov 21, 2019

📌 Commit 1b2de17 has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 21, 2019
@bors
Copy link
Contributor

bors commented Nov 21, 2019

⌛ Testing commit 1b2de17 with merge f11759d...

bors added a commit that referenced this pull request Nov 21, 2019
@bors
Auto merge of #66610 - alexreg:trait-upcasting-cosmetic, r=Centril
f11759d 
Aggregation of drive-by cosmetic changes for trait-upcasting PR

Cherry-picked from #60900.

As requested by @Centril (and @nikomatsakis, I believe).

r? @Centril
@bors
Copy link
Contributor

bors commented Nov 22, 2019

☀️ Test successful - checks-azure
Approved by: Centril
Pushing f11759d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 22, 2019
@bors bors merged commit 1b2de17 into rust-lang:master Nov 22, 2019
@bors bors mentioned this pull request Nov 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Centril Centril Centril left review comments

Assignees

@Centril Centril

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexreg @bors @Centril @rust-highfive