Display more informative ICE #67986
Display more informative ICE #67986
Conversation
|
r? @varkor (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
src/librustc/ty/layout.rs
Outdated
| @@ -2504,7 +2504,7 @@ where | |||
| }; | |||
|
|
|||
| let mut inputs = sig.inputs(); | |||
| let extra_args = if sig.abi == RustCall { | |||
| let extra_args = if sig.abi == RustCall && !sig.inputs().is_empty() { | |||
There was a problem hiding this comment.
This is just ignoring the error. We should be hitting the bug! below if we don't have any arguments. You just need to make the match more resilient.
There was a problem hiding this comment.
So, we should emit ICE like this instead of current one?
There was a problem hiding this comment.
Yes: the ICE with the error message is more informative and due to unboxed_closures being an unfinished feature. (So there's no need to add a test for this feature, as it's expected to ICE.)
There was a problem hiding this comment.
Got it, fixed and removed test. Shouldn't we close that issue via this PR?
JohnTitor
force-pushed
the
fix-ice-rust-call
branch
from
561761d
to
c524f3c
Compare
|
@bors r+ rollup |
|
📌 Commit c524f3c has been approved by |
bors
added
S-waiting-on-bors
Display more informative ICE Fixes rust-lang#66696
Rollup of 12 pull requests Successful merges: - #67630 (Treat extern statics just like statics in the "const pointer to static" representation) - #67747 (Explain that associated types and consts can't be accessed directly on the trait's path) - #67884 (Fix incremental builds of core by allowing unused attribute.) - #67966 (Use matches macro in libcore and libstd) - #67979 (Move `intravisit` => `rustc_hir` + misc cleanup) - #67986 (Display more informative ICE) - #67990 (slice patterns: harden match-based borrowck tests) - #68005 (Improve E0184 explanation) - #68009 (Spell check librustc_error_codes) - #68023 (Fix issue #68008) - #68024 (Remove `-Z continue-parse-after-error`) - #68026 (Small improvements in lexical_region_resolve) Failed merges: r? @ghost
Fixes #66696